question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

provide module info

See original GitHub issue

as stated in #30 cssfx is not modular.

we should remedy to that by:

  • either fixing the automatic module name
  • provide real module-info

Also the module name to expose must be defined:

  1. cssfx it is the current automatic module name:
    • good for compatibility reasons
    • bad for potential collisions in global namespace
  2. org.fxmisc.cssfx
    • avoid collisions by using the current groupId namespace
    • bad because out control, domain is owned by Thomas Mikula
  3. fr.brouillard.cssfx
    • avoid collisions by using an owned groupId namespace
    • its a controlled namespace (including for deployment in central)

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
FlorianKirmaiercommented, May 26, 2020

I don’t think 1 is a good solution. I would either do 3 combined with refactoring the existing classes or 2. Probably 2 because it’s easier and the drawback is relatively small.

0reactions
McFoggycommented, May 26, 2020

which probably takes more time because it requires registering the new domain to maven central

No I already own all the rights to fr.brouillard.oss for sonatype/central deployments.

I’ll prepare the move, do a PR and if OK for you & community I will publish later a 11.3 version. I do not want to jump to 12 because I’d like to keep some kind of synch/compatibility with the JVM/javafx version it targets.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Understanding Java 9 Modules - Oracle
A module descriptor is the compiled version of a module declaration that's defined in a file named module-info.java . Each module declaration begins...
Read more >
Java 9 Modules Cheat Sheet | JRebel & XRebel by Perforce
To declare a jar file as a named Java module, one needs to provide a module-info.class file, which is, naturally, compiled from a...
Read more >
A Guide to Java 9 Modularity - Baeldung
A Module is a group of closely related packages and resources along with a new module descriptor file. In other words, it's a...
Read more >
Java Modules - Jenkov.com
A Java module is a packaging mechanism that enables you to package a Java application or Java API as a separate Java module....
Read more >
dmlloyd/module-info - GitHub
A utility for generating module-info.class files from any JDK version (including 8). The module-info.class file is generated by reading a source YAML file, ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found