Mocha v3.1.0 finding global leak

Attn: @mde @TimothyGu

This morning I merged https://github.com/mde/ejs/pull/203. The build PR build was passing. This should not have affected anything. Changeset: https://github.com/mde/ejs/compare/5355a2cf4fbe...6c2663e347dd.

I received an email notifying me that the Travis Build had failed on master https://travis-ci.org/mde/ejs/builds/163080741. The log says:

87 passing (185ms)

  1 failing

  1) -%> stack traces work:

     Error: global leak detected: data

I cannot reproduce locally. I tried restarting the build just in case, it did not make a difference. The previous build worked fine: https://travis-ci.org/mde/ejs/builds/161735725.

I created a new branch test off of master and ran git reset --hard HEAD~ and pushed it to origin to see if that Travis build will pass. It doesn’t: https://travis-ci.org/mde/ejs/builds/163120705. This is the exact same commit as the passing https://travis-ci.org/mde/ejs/builds/161735725!

This seems to be a Travis bug. Advice?

[RyanZim]

OK, I will make a PR editing the ejs file.

[mde]

No, EJS can’t throw an error on globals. Globals are a bad practice, but they are valid JavaScript.