document.github_url has `master` branch in URL

Link in contributors.txt points to mdn/content branch master, which does not exist. It should be main branch.

Interestingly enough, when I run npm run build on local checkout, the produced files have correct URLs.

Example

Documentation pages have associated /contributors.txt files which list contributors to the individual pages. For example, for Web/API/Window it is at Web/API/Window/contributors.txt

Unfortunately, the link is incorrect, it has master in it:

# Contributors by commit history
https://github.com/mdn/content/commits/master/files/en-us/web/api/window/index.html

It should have main instead:

# Contributors by commit history
https://github.com/mdn/content/commits/main/files/en-us/web/api/window/index.html

[peterbe]

I think the problem is that we might be trying to be too smart. When it builds in production (the most important build), it all starts with a GitHub Action workflow that runs on a cronjob. It checks out the master branch of mdn/yari and within that workflow, it checks out the main branch of mdn/content. But I suspect that what’s happening is that process.env.GITHUB_REF refers to the ref of the mdn/yari branch, not the mdn/content one.

I suspect that this function actually dates back to the early days when the build JS code was all in the same repo as the en-US content. Then, it kinda made sense that the github_url for each document could be assumed to be same git checkout as that for the code.

@tannerdolby This issue might become complex and I intend to take an active role in solving it. But please stick around!

@escattone I’ve labelled this as a milestone blocker.

[peterbe]

master is gone