Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Download external images with the extension that it really is

See original GitHub issue

In https://github.com/mdn/content/pull/1587 @nschonni and I discovered that some images might be called foo.jpg but on closer inspection, it’s actually a image/png so the name is wrong. Who knows how many of these there are? The filecheck command will eventually catch you if you run the fixable flaws on external images that get downloaded to disk. Inconvenient when you have to manually correct it.

Issue Analytics

State:
Created 3 years ago
Comments:5 (1 by maintainers)

Top GitHub Comments

1reaction

peterbecommented, Jan 28, 2021

How do you check them? As far as I know there are „magic bytes” at the beginning of the image binary which can help deciding on the image.

I know, we decided to add images to the repo going forward, but an alternative might be to use an image CDN, which then would convert images on-the-fly. Could be used in the future, if the repo gets too large.

We use https://www.npmjs.com/package/file-type

0reactions

Ryuno-Kicommented, Jan 23, 2021

I was hinting on https://en.wikipedia.org/wiki/List_of_file_signatures or https://en.wikipedia.org/wiki/Magic_number_(programming)#Magic_numbers_in_files

On *NIX systems, you have the file CLI for this. Perhaps @peterbe found another way to do it (e.g. with Node tools). Thus my question.