Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

EmbedLiveSample errors should probably be fatal

See original GitHub issue

Suppose you have a perfectly working page with {{EmbedLiveSample('honkey_dory', ...)}}. It will generate a _samples_/index.html. And this gets uploaded, by the Deployer, to S3. But then you “mess” with the page such that at the next render, it can’t generate a new _samples_/index.html. You won’t notice this and the existing uploaded _samples_/index.html won’t be replaced.

Issue Analytics

State:
Created 3 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

peterbecommented, Jan 12, 2021

@escattone and I chatted about this at length and decided to consider making MacroEmbedLiveSample a fatal thing (rather than a flaw). We might need to do some mass editing one-off, if it’s feasible. Or we consider some other way to make it less subtle and confusing.

0reactions

peterbecommented, Apr 22, 2021

To get out of this funk, I just went ahead with making an exception specifically for en-US. Yesterday I fixed the last remaining MacroLiveSampleError in all of mdn/content.

So now, for en-US, it will crash the CI build, for for translated-content it will just be a console.warn https://github.com/mdn/yari/pull/3576