question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Good/bad code example design feels like a regression

See original GitHub issue

Sometimes code examples have the class example-good or example-bad to highlight good practises or bad practises. Originally these snippets had a green/red background colour, now they have tick/cross icons in the corner.

These icons are not only hard to miss, but seem a little mis-leading (the cross for instance looks like a user could ‘close’ the code example).

I don’t have a clear idea as to what the design improvement should be here (possibly green/red borders on the left?) but I think what we currently have isn’t particularly good.

https://developer.mozilla.org/en-US/docs/MDN/Guidelines/Code_guidelines/General#highlight_good_and_bad_practice_examples

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:2
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
Rumyracommented, Mar 22, 2022

Apart from restoring the background-color, an alternative to ✔️ / ✖️ would be 👍 / 👎 .

I’m unsure about restoring the background colour tbh - with the varied colours for sections now… It’s hard to envisage without seeing. I would be inclined to just try the border colour - I like the idea of thumbs up thumbs down - are there flat icons we can use instead of emoji?

1reaction
caugnercommented, Mar 21, 2022

Here is how it looked before (source):

image

Read more comments on GitHub >

github_iconTop Results From Across the Web

A Guide to Building Your First Regression Model in Just 8 ...
Mathematical modeling and machine learning can often feel like difficult topics to explore and learn, especially to those unfamiliar with ...
Read more >
Interpreting Residual Plots to Improve Your Regression
When you run a regression, Stats iQ automatically calculates and plots residuals to help you understand and improve your regression model.
Read more >
Coding Systems for Categorical Variables in Regression ...
Although our example uses a variable with four levels, these coding systems work with variables that have more categories or fewer categories. No...
Read more >
Practical Regression and Anova using R - R Project
The objective is to learn what methods are available and more importantly, when they should be applied.
Read more >
gw bootcamp review
To help give you an idea of what the UX design market looks like today, ... to this platform to discuss the reality...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found