PR review companion seems flaky?

On this build the PR review companion keep failing with the following stack:

Run actions/github-script@v5
  with:
    script: var artifacts = await github.rest.actions.listWorkflowRunArtifacts({
     owner: context.repo.owner,
     repo: context.repo.repo,
     run_id: 1480759121,
  });
  var matchArtifacts = artifacts.data.artifacts.filter((artifact) => {
    return artifact.name == "build"
  });
  if (matchArtifacts.length === 0) {
    console.warn(
      'No artifacts to download probably just means nothing ' +
      'was built in the "PR test" workflow. That\'s OK. ' +
      'This is actually not a genuine CI error.'
    );
    throw new Error(
      'No matched build artifacts. ' +
      'Perhaps nothing built in the "PR test" workflow'
    );
  }
  var matchArtifact = matchArtifacts[0];
  var download = await github.rest.actions.downloadArtifact({
      owner: context.repo.owner,
      repo: context.repo.repo,
      artifact_id: matchArtifact.id,
      archive_format: 'zip',
  });
  var fs = require('fs');
  fs.writeFileSync('/home/runner/work/content/content/build.zip', Buffer.from(download.data));
  
    github-token: ***
    debug: false
    user-agent: actions/github-script
    result-encoding: json
(node:1562) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
No artifacts to download probably just means nothing was built in the "PR test" workflow. That's OK. This is actually not a genuine CI error.
Error: No matched build artifacts. Perhaps nothing built in the "PR test" workflow
    at eval (eval at callAsyncFunction (/home/runner/work/_actions/actions/github-script/v5/dist/index.js:4942:56), <anonymous>:17:9)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at async main (/home/runner/work/_actions/actions/github-script/v5/dist/index.js:4997:20)
Error: Unhandled error: Error: No matched build artifacts. Perhaps nothing built in the "PR test" workflow

We recently changes github.actions.listWorkflowRunArtifacts to github.rest.actions.listWorkflowRunArtifacts because of the breaking change in the underlying GitHub action. The same change was made by @SphinxKnight on translated-content. It looks like the error is not related to the change, but based on the fact that there was no artefacts. However, there is this console.warn in the code:

console.warn(
      'No artifacts to download probably just means nothing ' +
      'was built in the "PR test" workflow. That\'s OK. ' +
      'This is actually not a genuine CI error.'
    );

There is also this run that did not error. We will need to have a look at what the actual cause is and resolve the issue.

[SphinxKnight]

From https://github.com/mdn/translated-content/actions/workflows/pr-review-companion.yml?query=is%3Afailure I can see https://github.com/mdn/translated-content/actions/runs/1831126327 / https://github.com/mdn/translated-content/runs/5171601783?check_suite_focus=true and https://github.com/mdn/translated-content/runs/5176772124?check_suite_focus=true “recently”. Most of the time it goes without issues though.

I’ll be back later with more time to have a deeper look at those failures.

Edit: seems indeed pretty frequent for mdn/content as well : https://github.com/mdn/content/actions/workflows/pr-review-companion.yml?query=is%3Afailure

[wbamberg]

FWIW I’m also not seeing built pages for https://github.com/mdn/content/pull/10646 (the first time it worked, but after review the author made some changes, and those I am not seeing).