PR updates not picked up by PR companion?

Great work on the preview URLs / the PR companion. Really love this!

In https://github.com/mdn/content/pull/4048 innerHTML was updated to textContent in the code example but I still see innerHTML here: https://pr4048.content.dev.mdn.mozit.cloud/en-US/docs/Web/API/Document/caretPositionFromPoint

If a content PR sees updates, does the PR companion update the preview? Or is it caching on some side that prevents me from previewing the most current version of a PR?

[escattone]

Just saw this, hi @Elchi3! I went ahead and disabled caching on the *.content.dev.mdn.mozit.cloud domains, since there’s really no need for it (other than mimicking the functionality of stage and prod). So this issue should be resolved. Thanks for letting us know @Elchi3!

If we decide later that we’d like some caching, I could re-enable it and force it to something like a few minutes, but I don’t see the need at this point in time.

[peterbe]

Just saw this, hi @Elchi3! I went ahead and disabled caching on the *.content.dev.mdn.mozit.cloud domains, since there’s really no need for it (other than mimicking the functionality of stage and prod). So this issue should be resolved. Thanks for letting us know @Elchi3!

If we decide later that we’d like some caching, I could re-enable it and force it to something like a few minutes, but I don’t see the need at this point in time.

That will disable the ability to push a branch of testing some web perf feature in Yari. E.g. my branch where I experimented with doing some lazy-loaded BCD tables.

I would much prefer that we do this in the Deployer. We’re very explicit about calling the Deployer. The call to poetry run deployer upload ... is distinct in the PR Review Companion compared to dev-build.yml. I’ll make a PR about it and perhaps if that works, we can set the default caching back on that CloudFront instance.