question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Small alignment issue for star icon in browser compatibility tables

See original GitHub issue

In between 1199px and 1288px viewport width, the star icon that is stored in the pseudo element ::before is slightly off center in the browser compatibility table. I’m viewing it on this page dragenter event but it should be the same for each BC table.

Screen Shot 2021-01-20 at 9 07 27 PM Screen Shot 2021-01-20 at 9 15 17 PM

This is due to the margin-left: 6px property on .bc-icons i:before which plays nice for every other responsive layout but between 1199px-1288px it has this small off center appearance.

Updating that property to margin-left: 2px provides a much more centered alignment of the star icon.

Screen Shot 2021-01-20 at 9 19 48 PM Screen Shot 2021-01-20 at 9 52 09 PM

The above seems to be much more centered. This makes the area that the media query would cover be from 1199px-1223px. Then the margin-left: 6px would be applied again as the media condition wouldn’t be used outside that range.

I remember seeing how media queries worked on the .scss end and the “mobile-first” approach, so I’m not sure if you think its “worth it” to add such a small media query to better center the star icon but let me know your thoughts.

@media (min-width: 1199px) and (max-width: 1223px) {
  .bc-icons i:before {
     background-size: 18px;
     ...
     margin-left: 2px;
  }
}

Lastly, the .bc-history affects two other places where the star icon is styled by .bc-icons i:before, in the see implementation notes, and in the footnotes dropdown which does reduce the space in between the text and icon a bit since the container is larger and doesn’t wrap to the next line like it does in the BC table. This looks squished with 2px so the footnotes box from the dropdown should retain the 6px margin left to not look like below.

Screenshot with margin-left: 2px added Screen Shot 2021-01-20 at 9 48 12 PM

Screen Shot 2021-01-20 at 9 45 33 PM

This is a lot of tinkering just to provide a little better centering for a small range of viewport widths so I understand if its not feasible, just wanted to bring it up.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:10 (9 by maintainers)

github_iconTop GitHub Comments

2reactions
peterbecommented, Jan 21, 2021

If you can correct that, I think it would make a big improvements. I’ve noticed little imperfections like that too and it looks kinda “sloppy” which leaves a bad taste. It shouldn’t matter, but it does. We’re just fancy monkeys.

1reaction
tannerdolbycommented, Jan 26, 2021

@Ryuno-Ki Sounds good. Thank you for the clarification.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Fix site display issues with Compatibility View in Internet ...
Not all website display problems are caused by browser incompatibility. Interrupted Internet connections, heavy traffic, or problems with the website can also ...
Read more >
Material Icons - Vertical Align Doesn't work well alongside text ...
Material icons doesn't seems to vertical align themselves when placed alongside any text.
Read more >
Material Symbols and Icons - Google Fonts
Introducing Material Symbols. Material Symbols are our newest icons consolidating over 2,500 glyphs in a single font file with a wide range of...
Read more >
Browser Compatibility Guide for PeopleSoft Applications
Zooming on iOS on small form factor devices creates an unsatisfactory user experience. Work-Around. This issue has no work-around. Bug 23115155. If the...
Read more >
<th>: The Table Header element - HTML - MDN Web Docs
The HTML element defines a cell as header of a group of table cells. The exact nature of this group is defined by...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found