Namespaces not taken into account

I wanted to distill views from an app (via python manage.py distill-local), but I think distill does not take namespaces into account… I tried with following setup:

# base urls.py
urlpatterns = [
    ...
    path("", include("djagora.map.urls", namespace="map")),
]

# map/urls.py
app_name = "map"

urlpatterns = [
    ...
    distill_path(
        "some_view/",
        view=views.SomeView.as_view(),
        name="some",
    ),
]

But this lead to an error when generating uri: https://github.com/meeb/django-distill/blob/ea6132b6c21c73265c5b80389c9fb448c9eb7297/django_distill/renderer.py#L81 as view_name only contains "some", but correct reverse name would be "map:some". After setting view_name = "map:some" within debugging mode, script goes on without error (giving me some errors later, but this does not belong here). Can you confirm this error, or am I missing something?

[meeb]

In the just pushed commit adds partial namespace support including nested namespaces. The only situation where namespaces are not supported is include()ing the same set of URLs more than once on the same project, which will raise a polite and detailed error. So this is fine:

urlpatterns = [
    path('namespace/',
        include('someapp.urls', namespace='namespace')),
    path('namespace/',
        include('anotherapp.urls', namespace='anothernamespace')),
]

But this will throw an error:

urlpatterns = [
    path('namespace/',
        include('someapp.urls', namespace='namespace')),
    path('namespace2/
        include('someapp.urls', namespace='namespace2')),
]

As in, including someapp.urls more than once in the same project. Different URLs are fine. This is because the only sane way to map URLs to their namespace is to use the URL function itself (which matches the id(urlfunc) in most Python interpreters). The second example would reference the same URL more than once, making it impossible to work out which namespace it belongs to. Hopefully this partial implementation is sufficient for all but the most unusual deployments.

[meeb]

I’ll write a test case to check for namespaced inclusion and push any fixes into the next distill release when I get a moment.