create_config, not .config

We should make the API for “get a TorConfig instance” async and call it .create_config, not .config on the Tor class.

Also, .connect and .launch should not use TorConfig at all. It is already “not really” exposed in the API (there is a _tor_config for tests (and .global_tor()?) but it shouldn’t be used and the docs say that).

The use-case for this is cutting down on the number of GETCONF calls for “filtering proxies” (such as Whonix and SubGraph use to limit access to the tor control port). This is also the only “implied” object created, so it would be nice to eliminate it, making all additional “helper” object things that are created from Tor methods.

Thanks to @felipedau for bringing this use-case up. See also: https://github.com/AnemoneLabs/unmessage/issues/4#issuecomment-285561506

[meejah]

Great, thanks for testing @felipedau !

[meejah]

@felipedau Thanks for the feedback 😃 No, I can’t think of any reason someone would need more than 1 TorConfig per tor instance they’re talking to, especially in one process.