Error when "font-weight" is present on html

Whenever i try to render a page which contains font-Weight, i get the following error:

Warning: Failed prop type: Invalid prop fontWeight of value 400 supplied to Text, expected one of [“normal”,“bold”,“100”,“200”,“300”,“400”,“500”,“600”,“700”,“800”,“900”]. Bad object: { “marginTop”: 14, “marginBottom”: 14, “fontWeight”: 400 } in Text (at HTML.js:460)

[ghost]

I stumbled upon a weird issue which caused this error in the following HTML:

<h5><strong>Text <img src="https://upload.wikimedia.org/wikipedia/commons/thumb/3/37/Small-world-network-example.png/220px-Small-world-network-example.png" alt="sample_image" /></strong></h5>

with fontWeight: '500' set in tagStyles for both h5 and strong.

After removing <strong> or <img> everything works properly. It seems that the string value gets converted to a number in the child Text component. I managed to find a hacky way to get around this by modifying source code of this library from https://github.com/archriss/react-native-render-html/blob/60d53598e35f5cf36d89a5c9a526d85a9744288f/src/HTMLStyles.js#L143 to

       if (value.search('px') !== -1 && !isNaN(numericValue)) {

I’m not sure if this is the right way to tackle this problem though and if it would not cause some other issues. Do you have any suggestions?

[ghost]

@Exilz Yes, you’re right - my initial solution would result in problems with other styles like margin: 3 or font-size: 12 (without px). Filtering just fontWeight is enough for now I guess. I’ll try to submit a PR later tonight.