chore: limit `feature_flag` method to `ProjectSettingsService`
See original GitHub issueFollowing up on this discussion in #6485.
Currently the feature_flag
decorator is a method defined on the SettingsService
base class. However, since feature flags are top-level settings in a Meltano project and currently never defined in plugin settings, this has led to multiple cases of the method being used from a PluginSettingsService
, where it will always show the given flag as not being set. To avoid this confusion, we should just move the method to ProjectSettingsService
.
Issue Analytics
- State:
- Created a year ago
- Reactions:3
- Comments:7 (4 by maintainers)
Top Results From Across the Web
Feature Toggles (aka Feature Flags) - Martin Fowler
Feature Toggles (often also refered to as Feature Flags) are a powerful technique, allowing teams to modify system behavior without changing code.
Read more >Feature flags - GitLab Docs
Create a feature flag · On the top bar, select Main menu > Projects and find your project. · On the left sidebar,...
Read more >Feature Flags—What Are Those? Uses, Benefits & Best ...
Feature flags are a software development concept that allow you to enable or disable a feature without modifying the source code or requiring...
Read more >Feature Flags Best Practices (Feature Toggles) - Harness
Feature flags are a way that developers can conditionally turn certain sections of their code (or code paths) on or off.
Read more >Progressive experimentation with feature flags - Azure DevOps
Flags also provide granular control all the way down to the individual user. When it's time to enable a feature, whether for one...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
@cjohnhanson the weight field is on the Engineering Assignments board which this wasn’t assigned to when you opened it. Leaving a comment is fine as it does help with prioritization prior to being pulled into that board.
@aaronsteers yeah I put this on the backburner since it’s definitely a chore that doesn’t have any immediate or short-term user impact. It should definitely have the
Urgency=High
flag removed.