question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

feat: remove requirement for `PLUGIN_TYPE` positional arg in CLI commands `meltano add`, `meltano remove`, `meltano install`

See original GitHub issue

Currently in the CLI only the meltano add and meltano remove commands require you to specify the plugin type.

Other commands default to just referencing the name while enabling a user to specify --plugin-type if necessary. Commands that accept --plugin-type:

Proposal

Drop the requirement for <type> when using meltano add and remove so that users can type:

meltano add tap-gitlab or meltano remove target-postgres and Meltano can just figure that out. When there is a collision a we can error out, tell the user there are multiple plugins with that name present and have them disambiguate.

When a user is adding a --custom plugin, we can infer the type from the name (pattern match on tap and target) and/or prompt them for a type. We should likely just ask is this an extractor, loader, or a non-connector (utility).

Issue Analytics

  • State:open
  • Created 9 months ago
  • Reactions:4
  • Comments:10

github_iconTop GitHub Comments

1reaction
aaronsteerscommented, Dec 13, 2022

What about the top-level index here:? hub.meltano.com/meltano/api/v1/plugins/index It includes a ref for all variants, as well as the name of the default variant. We’d have to page through the types, but locally that iteration would be pretty quick.

@aaronsteers yeah that’d probably be faster, if still pulling more data than it needs.

Thanks for confirming. Agreed it’s perhaps slightly more than needed, but at least not an order of magnitude greater. One option for the future optimized version would likely take some search parameters like ‘plugin name’ and perhaps offer pagination if the resultset is too large. But that said, not being static, I don’t know if the optimized version would be much faster even if returning less data. 🤷 (We can analyze+discover when we get there. 😄 )

1reaction
edgarrmondragoncommented, Dec 13, 2022

What about the top-level index here:? hub.meltano.com/meltano/api/v1/plugins/index

It includes a ref for all variants, as well as the name of the default variant.

We’d have to page through the types, but locally that iteration would be pretty quick.

@aaronsteers yeah that’d probably be faster, if still pulling more data than it needs.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Command Line - Meltano Documentation
Meltano provides a command line interface (CLI) that makes it easy to manage your project, plugins, and EL(T) pipelines.To quickly find the meltano...
Read more >
Taylor A. Murphy tayloramurphy - GitHub
feat : remove requirement for PLUGIN_TYPE positional arg in CLI commands meltano add , meltano remove , meltano install. Currently in the CLI...
Read more >
Resolve "Add `meltano remove <type> <name>` command to ...
Remove plugin installation from .meltano; Remove plugin data from the system database; Batch removal of plugins of the same type (same as meltano...
Read more >
meltano - PyPI
yml file and installs in .meltano directory with venvs , dbt and pip . meltano install : Installs all the dependencies of your...
Read more >
Meltano Meltano Issues - IssueHint
feat : remove requirement for `PLUGIN_TYPE` positional arg in CLI commands `meltano add`, `meltano remove`, `meltano install`, open, 10, 2022-12-09, 2022-12-17.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found