Meltano `config list` and `config set` should print settings with `kind:secret` as `(redacted)`

As reported in slack and I have confirmed locally.

Currently meltano config set will print the setting value in clear text after setting it, and similarly, config list will print the secret value in clear text as well.

Proposed changes:

1. meltano config set would print (redacted) in place of the setting value when confirming that the value has been stored.
2. meltano config list would print (redacted) in place of the current value when printing the list of all settings.

cc @tayloramurphy

[aaronsteers]

@DouweM - Thanks for the extra context. It’s pretty common for secrets to be set in a one-way capacity, without visibility after the value being set. (GitHub does this, for example. Once set, you can override the value but not view it.)

I would personally lean towards also redacting on meltano config (with no subcommand) but adding something like --secrets --with_secrets or --secrets=true allowing users to skip redactions.

[DouweM]

@aaronsteers @tayloramurphy I think we should still have some way to verify it’s been set correctly. We had a bug in the past where env-var expansion would accidentally remove anything following a $ from a password, for example, that would be hard to identify without being able to see what Meltano will actually pass on to the plugin.

A new flag on config list perhaps? Or do you think meltano config showing the unredacted value will be sufficient (assuming you left that one out in the description on purpose)?