`meltano lock` -> variant 'original' is not known to Meltano

I’m getting the following error when I’m trying to run a meltano lock --all on the squared project (note, I did first manually updated to remove executable and namespace which were defined in my project). When I commented out the inherit_from children it works, the plugin is locked, then uncommenting the children again makes it fail again so I’m pretty sure its related to the inheriting.

File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/core/project_plugins_service.py", line 521, in get_parent
    parent, source = self.find_parent(plugin)
  File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/core/project_plugins_service.py", line 510, in find_parent
    raise error
  File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/core/project_plugins_service.py", line 505, in find_parent
    return (self._get_parent_from_hub(plugin), DefinitionSource.HUB)
  File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/core/project_plugins_service.py", line 441, in _get_parent_from_hub
    return self.hub_service.get_base_plugin(plugin, variant_name=plugin.variant)
  File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/core/plugin_discovery_service.py", line 136, in get_base_plugin
    plugin = project_plugin.custom_definition or self.find_definition(
  File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/core/hub/client.py", line 189, in find_definition
    raise HubPluginVariantNotFound(
meltano.core.hub.client.HubPluginVariantNotFound: Extractor 'tap-github' variant 'original' is not known to Meltano. Variants: ['singer-io (default)', 'meltanolabs']

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/Users/pnadolny/.virtualenvs/meltano/lib/python3.8/site-packages/meltano/cli/__init__.py", line 74, in _run_cli
    raise CliError(str(err)) from err
meltano.cli.utils.CliError: Extractor 'tap-github' variant 'original' is not known to Meltano. Variants: ['singer-io (default)', 'meltanolabs']
Extractor 'tap-github' variant 'original' is not known to Meltano. Variants: ['singer-io (default)', 'meltanolabs']

[edgarrmondragon]

Just to be clear, the scope of this is to:

• update meltano lock to skip inherited plugins
• update https://docs.meltano.com/concepts/plugins#lock-artifacts to indicate as much

That seem accurate?

@tayloramurphy yup, that is right

[DouweM]

@pnadolny13 Just to confirm, you’re saying that meltano lock --all worked with only this:

plugins:
  extractors:
  - name: tap-github
    pip_url: git+https://github.com/MeltanoLabs/tap-github@d99378778c0cebc446c12b552ee4fd386fdc2610
    capabilities:
    - catalog
    - discover
    - state
    settings:
    - name: auth_token
      kind: password

But not when this was (re)added:

plugins:
  extractors:
  # ...
  - name: tap-github-meltano
    inherit_from: tap-github
    config:
      organizations:
      - MeltanoLabs
      - meltano
      stream_maps:
        issues:
          __filter__: record['type'] = 'issue'

I wonder why in that first case with only tap-github, we didn’t hit the same error as https://github.com/meltano/meltano/issues/6360, which I’d expect any time there’s a name but no variant (and no namespace to indicate a custom plugin, or inherit_from to indicate an explicitly inherited one).

remove executable/namespace if defined

I don’t think we should recommend this: namespace is still supported and valuable, as it indicates custom plugins that shouldn’t be looked up on the Hub (see also https://github.com/meltano/meltano/issues/3296#issuecomment-1166157626 about why we can’t just remove that property).