`metadata` and other extras of kind `object` not honored when using environments

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/3400

Originally created by @tbriggs2 on 2022-04-14 20:18:50

---

What is the current bug behavior?

If the metadata extra is defined in the base configuration of an inherited plugin it is not respected - the metadata from the base configuration of the parent plugin is used instead.

What is the expected correct behavior?

The metadata extra from the inherited plugin definition should be used.

Steps to reproduce

Using the attached meltano.yml run

meltano --environment=prod run tap-mysql2 target-jsonl

SomeTable2 will get replicated but with replication-method=LOG_BASED. If instead you run

meltano --environment=dev run tap-mysql2 target-jsonl

SomeTable2 will be replicated using replication-method=FULL_TABLE as expected. The point being that this appears to be a problem specifically with metadata defined on the base inherited plugin only.

Note also that if you change the metadata in the base parent plugin to not use a wildcard, i.e.

    metadata:
      SchemaName-SomeTable:
        replication-method: LOG_BASED

The pipeline will fail with an error about the replication method not being defined for SomeTable2. I think that’s relevant because it shows that the wildcard isn’t overriding the inherited plugin configuration.

Further regression test

Ensure we automatically catch similar issues in the future

• Write additional adequate test cases and submit test results
• Test results should be reviewed by a person from the team

[edgarrmondragon]

can you make a follow-up issue for whatever isn’t fixed in #6376 ?

@tayloramurphy done: https://github.com/meltano/meltano/issues/6380

[tayloramurphy]

@edgarrmondragon sounds good - can you make a follow-up issue for whatever isn’t fixed in #6376 ?