question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Method to 'lock' plugins in a project and update existing lock files

See original GitHub issue

So that we can fully move off of discovery.yml, we should add a method to lock all plugins.

@aaronsteers from your last comment on the GitLab issue, will you create a relevant “lock all” issue? I’m not seeing one in https://github.com/meltano/meltano/issues?q=is%3Aissue+is%3Aopen+lock

Proposed spec details:

_Originally posted by @tayloramurphy in https://github.com/meltano/meltano/issues/5925#issuecomment-1141520551_

Issue Analytics

  • State:closed
  • Created a year ago
  • Reactions:1
  • Comments:9

github_iconTop GitHub Comments

1reaction
aaronsteerscommented, Jun 4, 2022

Agreed with @edgarrmondragon. - I don’t feel very strongly either - but we should try to have consistent practices.

I think my preference would be --all but in certain contexts --all is optional when otherwise implied, and would likely be the default behavior if nothing different is requested.

If we went this direction, basically all of these to be equivalent ways to say ‘all’:

meltano discover
meltano discover --all
meltano discover all      # already exists
meltano install
meltano install --all
meltano lock
meltano lock --all
meltano job list
meltano job list --all
meltano test -all
meltano test <plugin_name>
meltano test <plugin_name> --all

Also related: ‘interactive’ #3153 .

When there’s really no other way to run the command besides --all, we likely would leave it off. meltano job list is a good example of where there’s no other way to run this. But in future, if we have a --filter option, then --all would make more sense. Again, it likely is the default behavior but it could improve readability if there’s any confusion.

1reaction
edgarrmondragoncommented, Jun 2, 2022

@aaronsteers Yup, that looks good

Read more comments on GitHub >

github_iconTop Results From Across the Web

Locking dependency versions - Gradle User Manual
Enabling locking on configurations; Generating and updating dependency locks; Lock state location and format; Running a build with lock state present ...
Read more >
Dependency Locking - API Manual
Lock all configurations in one build execution​​ For this, you have two options: Run gradle dependencies --write-locks . This will effectively lock all ......
Read more >
Ability to disable lockfiles · Issue #31533 · hashicorp/terraform
In each configuration working directory, run terraform init -upgrade to select the newest available versions that meet the constraints specified ...
Read more >
What is package lock json? Lockfiles for yarn & npm ... - Snyk
Package lock files serve as a rich manifest of dependencies for projects that specify the exact version of dependencies to be installed, ...
Read more >
The Ultimate Guide to yarn.lock Lockfiles - Andrew Hansen
Don't regenerate yarn.lock · Use auto merge conflict resolution · Be explicit about updating dependencies by only updating through your project's ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found