revert: project-name in project_id
See original GitHub issueIn https://github.com/meltano/meltano/pull/6621 we added the project name
to the project_id on init
. Even though we hash the id prior to sending, its addition was unnecessary and creates a few problems:
- having the project name in the id confuses the purpose of the id. We don’t need to know or include the directory name in the project id and its inclusion sends the wrong signal that we do care about it somehow
- while it’s true that
project_id
can be any string, we generally don’t want to encourage folks to change it unless they have a strong reason to - when trying to correlate local testing to events we’re seeing through our production snowplow pipeline, having to hash the id is unnecessarily burdensome when we’d rather just look for the GUID itself
I would support a documentation update to make it clear that project_id
can be any string but that it’s generally not recommended to update if you don’t need to.
Also, I did notice that as part of this update it seems like project_id
gets put at the end of the file - is there anyway to bring that back up above the environments?
Issue Analytics
- State:
- Created a year ago
- Comments:6 (3 by maintainers)
Top Results From Across the Web
Creating and managing projects - Documentation
Don't include sensitive information in your project name, project ID, or other resource names. ... To restore a project using the Google Cloud...
Read more >How can I rename the Firebase Project ID? - Stack Overflow
Note that Ettore's answer allows you to change the name (2x) of a project, but not the ID. I'm pretty sure the project...
Read more >Locate the project ID - API Console Help - Google Support
Locate the project ID · Go to the API Console. · From the projects list, select Manage all projects. The names and IDs...
Read more >Is it possible (supported) to change a PROJECT NAME
Hi Simon, As you've seen, there are two independent names - the project name, used only for display purposes, which you can change...
Read more >Solved: Is there any API to retrieve a project ID by passi...
Solved: For our automation testing - Users will pass 'Project Name', 'Version Name' and 'Cycle Name' in the test suit Json, we are...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Thanks @edgarrmondragon. In any case, that should be handled as a separate issue from the default project ID format. @tayloramurphy
@WillDaSilva it was discussed back in the ruamel PR: https://github.com/meltano/meltano/pull/6308#issuecomment-1176596663. There’s a bit of complexity involved in enforcing a position for certain keys, but it’s definitely doable.