Attach comments

I’m trying to use attachComments functionality of escodegen, which gets tree,comments,tokens as arguments.

Unfortunately, it doesn’t preserve the comments using Meriayh and it looks like the tokens types and range are different than what escodegen expect to have.

I tried the following scenario:

`

const sourceCode = `
  //Comment1
  const test1 = 1;
  //Comment2
  const test2 = 2;
`;
let tokens = [];
let comments = [];
let tree = meriyah.parse(sourceCode, {
  ranges: true,
  globalReturn: true,
  onToken: function (type, start, end) {
    let value = this.tokenValue ? this.tokenValue.toString() : '';
    tokens.push({type: type, value: value, range: [start, end]});
  },
  onComment: function (type, value, start, end) {
    type = type === 'SingleLine' ? 'Line' : type;
    type = type === 'MultiLine' ? 'Block' : type;
    comments.push({type: type, value: value, range: [start, end]});
  }
});
replaceStartEndToRange(tree);

tree = escodegen.attachComments(tree, comments, tokens);
const res = escodegen.generate(tree, {
  sourceCode: sourceCode,
  format: {
    compact: false,
    preserveBlankLines: true
  },
  comment: true
});
expect(res).to.be.equal(sourceCode);

`

sourceCode: //Comment1 const test1 = 1; //Comment2 const test2 = 2;

res: const test1 = 1;

 const test2 = 2;

As you can see, the comments are missing.

I use “meriyah”: “1.9.12” “escodegen”: “1.14.1”

BTW, it works with Esprima.

Thanks, Niv

[mamaniv]

Works now. Thank you!

[KFlash]

Released v. 1.9.14.