question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Need to process win32 line break correctly

See original GitHub issue

I noticed we skipped lots of test files in test262-parser-tests, I tried to unblock them to see what happens.

For example the first skipped file: https://github.com/meriyah/meriyah/blob/756d990eb3c98487197bade97cb5d34f77a86ea0/test/test262-parser-tests/parser-tests.ts#L9

The 110fa1efdd0868b8.js file contents is

"Hello\
world"

But the file is using win32 line break \r\n which causes issue in meriyah.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:15 (15 by maintainers)

github_iconTop GitHub Comments

1reaction
3cpcommented, Oct 30, 2020

It turns out a very small bug in existing code, it was sitting there because of missing test coverage. Let’s just patch it for now, worry about the bigger refactoring later.

0reactions
KFlashcommented, Oct 29, 2020

No reason. I just tried to avoid assigning of the variable inside the loop. Costs memory. It was all done fast and without too much thinking.

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to writefile in new line in WIN32 API - Stack Overflow
Windows uses a CR/LF combination to signify the end of line, you need to write "\r\n" if you want the line break to...
Read more >
How to Use Word and Line Break Information - Win32 apps
A rich edit control calls a function called a word-break procedure to find breaks between words and to determine where it can break...
Read more >
CRLF vs. LF: Normalizing Line Endings in Git
With a file, it suffices to define the newline character as implicitly doing the job of both a line feed and a carriage...
Read more >
Line Breaks in Windows, UNIX and Macintosh Text Files
Very few applications can properly handle files with mixed line break styles. Simply select the line break style you want (Windows, UNIX, Mac)...
Read more >
windows - Difference between '\n' and '\r\n'
Printers have a separate command to move the paper up one line to a new line, ... has facilities to write the correct...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found