question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Upgrade to Angular13 fails

See original GitHub issue

When I upgraded to Angular 13 this morning - I started receiving this error

Error: node_modules/ngx-material-file-input/lib/file-input/file-input.component.d.ts:9:22 - error TS2720: Class 'FileInputComponent' incorrectly implements class 'MatFormFieldControl<FileInput>'. Did you mean to extend 'MatFormFieldControl<FileInput>' and inherit its members as a subclass?
  Type 'FileInputComponent' is missing the following properties from type 'MatFormFieldControl<FileInput>': stateChanges, errorState

9 export declare class FileInputComponent extends FileInputMixinBase implements MatFormFieldControl<FileInput>, ControlValueAccessor, OnInit, OnDestroy, DoCheck {

Would it be possible to get this issue fixed within the library?

Issue Analytics

  • State:closed
  • Created 2 years ago
  • Reactions:4
  • Comments:12 (6 by maintainers)

github_iconTop GitHub Comments

3reactions
damogallaghercommented, Nov 11, 2021

Had a quick review of your pr @mcaden and it looks good. Would be great if @merlosy could review and merge as this is blocked our upgrade to Angular 13

2reactions
mcadencommented, Nov 17, 2021

I can… it feels a bit like hijacking so I don’t think it’s my first choice. I’m not entirely sure the etiquette on this?

What I’ve done in the meantime that is working for me is that my consuming project is using yarn 2 with zero-installs

  1. build my fork
  2. use yarn pack in the built directory (dist\material-file-input)
  3. copy the resulting file to my consuming project
  4. remove reference to ngx-material-file-input
  5. yarn add ./<packed filename>
  6. delete packed file

The packed file is copied into the .yarn/cache folder and gets committed (which is why yarn 2 with zero-installs is a requirement for this approach).

I don’t like it but it packages up my changes without stepping on toes.

I respect the maintainer for this project and appreciate the work done. I also respect he may be super-busy at the moment and this project is a lower priority. Hopefully somebody with write-privileges will be able to approve the PR (or suggest where I might improve it so it can be approved).

Before I publish a fork I want to verify whether the project is abandoned.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Upgrade angular 13 - failure · Issue #148 - GitHub
When following the step by step upgrade guide from 12 to 13, we are supposed to execute the following command npx @angular/cli@13 update...
Read more >
Unable to upgrade from angular 12 to angular 13
it looks like an issue with npm. i have "npm --version" --> 8.5.4 but it is mentioned that version 7.x produces same error....
Read more >
Angular 13 - 14 migration - YouTube
In this video you will learn how to update angular version from 13 to 14 using angular update guide.Angular update guide ...
Read more >
Upgrade From Angular 12 to 13 - YouTube
I decided to record myself updating the application from the LearnWith book series from Angular 12 to Angular 13.
Read more >
Upgrading from AngularJS to Angular
Correspondingly, when you upgrade an AngularJS component and use it from Angular, all the bindings defined for scope (or bindToController ) of the...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found