0.60 fails to build GNOME components

Using the new meson 0.60, either from upstream or Debian, GNOME components started to fail to build

Example of the eog snap build https://launchpadlibrarian.net/565502418/buildlog_snap_ubuntu_focal_amd64_eog_BUILDING.txt.gz

Configuring org.gnome.eog.desktop.in using configuration

../src/data/meson.build:25:5: ERROR: Function does not take positional arguments.

Trying to build the current eog deb in Ubuntu with the new meson 0.60 deb from Debian unstable leads to a similar error

[eli-schwartz]

There is more than enough time between now and the next feature release of meson, for projects to fix their code.

It’s a simple and backwards-compatible fix, just remove a completely ignored argument and backport it to any stable maintenance branches you have.

It’s not even incorrect to fail here. It was never allowed. Meson has added a lot of improved type checking in recent years, which made many things that used to be silently ignored, turn into errors. We didn’t add deprecation warnings for any of it. Anyone who is passing incorrect arguments should in fact be told what they’re doing isn’t actually doing what they think it is doing, and their meson.build files are buggy.

That’s not a matter of backwards compatibility! That is a matter of bug-level compatibility.

This deprecation warning is being added as a courtesy gesture, because it turns out this one thing is surprisingly common among related projects and we want to give you time to fix things before your projects become unbuildable.

This is NOT permission to keep on using invalid arguments for another few years and another few major versions of meson! Fixing these bugs in the meson.build files should be prioritized IMO.

[xclaesse]

We should turn it into a deprecation warning for 0.60.1 and keep it removed in master. Does it break many GNOME projects? I guess it’s the kind of mistake that got copy pasted everywhere?