The `check` argument of `run_command` should be `True` by default

The run_command argument takes a check bool-argument. If check: true, is given and the command fails, meson will error out.

May I ask, who thought that it was a good idea to let check default to false? Ignoring errors by default goes against everything I learned.

So essentially, I want something like this, (plus documentation updates)

diff --git a/mesonbuild/interpreter/interpreterobjects.py b/mesonbuild/interpreter/interpreterobjects.py
index fca371cbc..3b3218c54 100644
--- a/mesonbuild/interpreter/interpreterobjects.py
+++ b/mesonbuild/interpreter/interpreterobjects.py
@@ -163,7 +163,7 @@ class RunProcess(MesonInterpreterObject):
                  subdir: str,
                  mesonintrospect: T.List[str],
                  in_builddir: bool = False,
-                 check: bool = False,
+                 check: bool = True,
                  capture: bool = True) -> None:
         super().__init__()
         if not isinstance(cmd, ExternalProgram):
@@ -184,7 +184,7 @@ class RunProcess(MesonInterpreterObject):
                     subdir: str,
                     mesonintrospect: T.List[str],
                     in_builddir: bool,
-                    check: bool = False) -> T.Tuple[int, str, str]:
+                    check: bool = True) -> T.Tuple[int, str, str]:
         command_array = cmd.get_command() + args
         menv = {'MESON_SOURCE_ROOT': source_dir,
                 'MESON_BUILD_ROOT': build_dir,

[keszybz]

Please, please, always include the source line in messages like this. In large projects, hunting for the right line to fix is a pita.

[Volker-Weissmann]

OK, OK, I’m sorry that I mentioned it. The change is good.

No, No, it’s good that you mentioned it.

Good error messages are important.