question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Add ability to customize InstrumentedQueuedThreadPool

See original GitHub issue

Right now InstrumentedQueuedThreadPool can be constructed with default underlying values only by implicitly calling no-arg QueuedThreadPool constructor, which looks like this:

public QueuedThreadPool()
{
    this(200);
}

While I assume default logic might be useful in some cases, having an opportunity to tweak it is something I would really like to have (I have finely tuned threadpool in production).

If team is fine with this proposal I can provide a PR, which will add bunch of overloaded constructors.

Issue Analytics

  • State:closed
  • Created 4 years ago
  • Comments:10 (10 by maintainers)

github_iconTop GitHub Comments

1reaction
izeyecommented, Oct 15, 2019

@IgorPerikov I think @shakuzen will take care of this.

0reactions
IgorPerikovcommented, Oct 23, 2019

Cool, will start working on that soon then

Delegation instead of extension seems like it would avoid potential explosion of constructors needed, but I guess that won’t play well with XML configuration.

It would not play well also because there are too many methods in QueuedThreadPool that need to be implemented (via simple delegation). Constructors won’t bloat the code that much

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to override the thread pool in Spring Boot app
The thread pool in my case is InstrumentedQueuedThreadPool . ... @Override public void customize(JettyServletWebServerFactory factory) ...
Read more >
Release Notes - Dropwizard Metrics
Ability to get default metrics registry without an exception #1140 ... Allow setting a custom prefix for Jetty's InstrumentedQueuedThreadPool .
Read more >
How to Make Custom Sorting Headers in Tableau - phData
To get started, first set up the table you're looking to sort! Step 1: Add a new data source.
Read more >
Dropwizard Documentation - Read the Docs
If, at some point, you need to change the JSON field name or the Java field without affecting the other, you can add...
Read more >
Release Notes | Dropwizard
Add ConfigurationSourceProvider for reading resources from classpath #1314 ... Support for defining custom logging factories (e.g. native Logback) #996 ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found