Broken graphite metrics names with tags

Graphite tags always generate broken names due to DropWizard behavior.

From DropWizard, GraphiteReporter [1]: graphite.send(prefix(name, type.getCode()), format(value), timestamp); where name=“my.metric;tag=value” type.getCode() = “p99”

final string sent to graphite: “my.metric;tag=valuep99”

From graphite logs 08/05/2020 08:21:00 :: [tagdb] Tagging component.api.setStatus;host=mail.example.com.mean, component.api.sendTextMessage;host=mail.example.com.p95, component.api.join_meeting;host=mail.example.com.m1_rate, component.api.getConversations;host=mail.example.com.mean

Unless we patch DropWizard side i can’t see how this code may work

[1] https://github.com/dropwizard/metrics/blob/v4.1.7/metrics-graphite/src/main/java/com/codahale/metrics/graphite/GraphiteReporter.java#L351

[davide-baldo]

Wow, that was fast, kudo really, first time seeing a fix this fast.

In the medium-term if it’s ok i would like to open a PR(or new repo?) to integrate graphite directly without dropwizard for different reasons:

• the output formats are as simple as you can get, and can be handled in few hundred lines
• by default many unspecified metrics are sent, if you specify a percentile it gets added to the list, I had to rewrite GraphiteReporter to disable unwanted metrics
• maintaining dropwizard wrapper seems to be way more complex than supporting graphite
• metrics seems to have different behavior than expected (counters are absolute, and maybe more)
• in general, a it’s better to stay in-line with micromter guidelines as much as possible

[fitzoh]

PR has been updated to work with the Dropwizard SNAPSHOT, should be good to go once a release is cut.