Can't remove meters after a filter is added

MeterRegistry.remove() fails to remove metrics that were created before a commonTags() filter was applied. It seems to apply the filter to the metric ID before trying to look it up, and so it finds nothing, and fails to delete it.

Tested using the latest version (io.micrometer:micrometer-core:1.2.1).

Here is my test case:

import io.micrometer.core.instrument.Metrics;
import io.micrometer.core.instrument.Timer;
import org.junit.Test;

import java.time.Duration;

import static org.junit.Assert.assertNull;

public class RemoveMetricTest {

    /**
     * This passes as expected
     */
    @Test
    public void testRemoveMetric() {
        Timer testTimer = Metrics.globalRegistry.timer("testTimer");
        testTimer.record(Duration.ofMillis(10));
        Metrics.globalRegistry.remove(testTimer);
        assertNull(Metrics.globalRegistry.find("testTimer").timer());
    }

    /**
     * This fails - the Timer does not get removed
     */
    @Test
    public void testRemoveMetricAfterAddingFilter() {
        Timer testTimer = Metrics.globalRegistry.timer("testTimer");
        testTimer.record(Duration.ofMillis(10));
        Metrics.globalRegistry.config().commonTags("foo", "bar");
        Metrics.globalRegistry.remove(testTimer);
        assertNull(Metrics.globalRegistry.find("testTimer").timer());
    }
}

[cykl]

I just faced a similar issue with a slightly different setup.

My application registers meters using the globalRegistry. Two MeterRegistry are added to the globalRegistry at startup, each registry has its own MeterFilter. When the application removes a meter, it is removed from the CompositeRegistry but not from the two terminal registries as a meter has different Meter.Id in each registry. I can open a dedicated issue if it helps.

[admoca60]

I believe this is fixed along with #2354 - the test case in my original report now passes using version 1.6.3.

Exactly, as I wrote, the #2354 and #1597 are the same use case!