Incorrect putCount() implementation with CaffeineCacheMetrics
See original GitHub issueIn CaffeineCacheMetrics, the counter for put(…) is loadCount(). But the loadCount works with get(key, mappingFunc) , it seems not working with put(…)
@Override
protected long putCount() {
return cache.stats().loadCount();
}
I did not see any call to cache().statsCounter().recordPutSuccess() or recordLoadSuccess() in put(…)
Guess I misunderstood something? Shall we have a recordPutSuccess() and a putCount() method in CaffeineCacheMetrics?
Issue Analytics
- State:
- Created 3 years ago
- Comments:8 (5 by maintainers)
Top Results From Across the Web
CaffeineCacheMetrics (micrometer-core 1.0.3 API) - Javadoc.io
Record metrics on a Caffeine cache. protected long, putCount(). The put mechanism is unimportant - this count applies to entries added to the...
Read more >MicronautCaffeineCacheMetrics (micrometer 1.2.1 API)
Record metrics on a Caffeine cache. protected long, putCount(). protected java.lang.Long, size() ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
I created https://github.com/micrometer-metrics/micrometer/issues/2242 for this.
Thank you everyone for bringing this to our attention and providing the helpful details. With @izeye’s update to the JavaDoc, I’ll close this and we can follow-up with #2242.