Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Automated checks report: x icons are coded as no value

See original GitHub issue

Describe the bug

Icons on the automated checks report are coded as “no value” under Images -> Image function requirement

To Reproduce Steps to reproduce the behavior:

Go to https://www.washington.edu/accesscomputing/AU/before.html
Open FastPass
Run Automated checks
Export the report by click on the “Export result” button
Open the download file
Open the assessment (on the automated checks report file)
If prompted, start a new assessment
Go to Images test
Under Image function requirement, look at the Instances list
Enable the visual helper
Observe

On the Instances list: all the listed instances show Coded as: (no value) and Accessible name: (no value)
On the report: the visual helper highlight:
- On the Summary section, the icons for failed, passed and not applicable status
- Under Failed instances, each of the failed icons for each one of the failed rules

Expected behavior

Every image on the report (icon or otherwise) should be properly coded

Screenshots

Extension (please complete the following information)

OS: Windows 10.0.17763 Build 17763
Version: Canary 2019.7.11.26
Browser Chrome 75.0.3770.100 (Official Build) (64-bit)
Target Page https://www.washington.edu/accesscomputing/AU/before.html

Are you willing to submit a PR?

Yes

Did you search for similar existing issues?

Additional context

Interesting enough, the icons on each result section (Failed instances, Passed checks, Not applicable checks) are not highlighted by the visual helper (and thus, don’t show up on the Instance list)
This may be a false positive as the svg icons are place under a <div aria-hidden="true"> container (although, is not a direct child of said <div>)

Issue Analytics

State:
Created 4 years ago
Comments:5 (2 by maintainers)

Top GitHub Comments

1reaction

smoralesdcommented, Jul 18, 2019

@iamrafan On my first review of the issue, I though I found an element with aria-hidden="true" containing the icons but you’re right, there is none. So good news is this is not a false positive and the fix is actually quite simple! PR #959 is waiting for review to fix this issue.

Thanks for double checking on this!

0reactions

msft-github-botcommented, Jul 17, 2019

The team requires additional author feedback; please review their replies and update this issue accordingly. Thank you for contributing to Accessibility Insights!