question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[iOS][input validation error] [UX issue : Input view styling on validation error]

See original GitHub issue

Platform

What platform is your issue or question related to?

  • iOS

Author or host

Host - Teams iOS Client

Version of SDK

SDK 2.1.0 (Adaptive card v1.3)

Details

When there is an input validation error message on the card, the SDK adds the border and changes the border colour of the inputView.

The SDK gets the inputView from the input stack and applies a colour filter to it assuming that the inputView would use the default renderer and this logic is present in validate method in ACRInputLabelView.mm and there is no new host config to pick this border colour.

    self.stack.arrangedSubviews[1].layer.borderWidth = 1;
    self.stack.arrangedSubviews[1].layer.cornerRadius = 6.0f;
    self.stack.arrangedSubviews[1].layer.borderColor = UIColor.systemRedColor.CGColor;

But in case the host uses a custom input renderer with its inputView, the UX we want should be based on the current theme/host config. There is no place where the host can override this behaviour of getting the input view and applying the border/colour filter to it.

PFA screenshot of the default behaviour and expected host behaviour (teams client) :

Default behaviour : image

Expected behaviour : image

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
shalinijoshi19commented, Oct 7, 2020

@sowrabh-msft please see @jwoo-msft’s comments above. Thanks.

Read more comments on GitHub >

github_iconTop Results From Across the Web

CSS style not being applied with input-validation-error in ...
This is mainly a CSS question, but I have posted all relevant information to the process. First the code snippet for the view:...
Read more >
Input validation error overlaps with another and falls off ...
As you can see from the picture, I have issues with displaying my validation messages. I have three smaller inputs and if all...
Read more >
Should I make space for error messages in forms?
I'm designing an mobile app for both iOS and Android, which includes a form. The form has several required input fields that the...
Read more >
Best practice with error messages say what is wrong, or ...
Take a form where a user must input a positive integer. If they don't put in a correct value, say -1, the form...
Read more >
Designing Better Error Messages UX
Let's explore when error messages should live above input fields and ... If the page is fully refreshed upon validation, the error summary ......
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found