[iOS][input validation error] [UX issue : Input view styling on validation error]
See original GitHub issuePlatform
What platform is your issue or question related to?
- iOS
Author or host
Host - Teams iOS Client
Version of SDK
SDK 2.1.0 (Adaptive card v1.3)
Details
When there is an input validation error message on the card, the SDK adds the border and changes the border colour of the inputView.
The SDK gets the inputView from the input stack and applies a colour filter to it assuming that the inputView would use the default renderer and this logic is present in validate
method in ACRInputLabelView.mm and there is no new host config to pick this border colour.
self.stack.arrangedSubviews[1].layer.borderWidth = 1;
self.stack.arrangedSubviews[1].layer.cornerRadius = 6.0f;
self.stack.arrangedSubviews[1].layer.borderColor = UIColor.systemRedColor.CGColor;
But in case the host uses a custom input renderer with its inputView, the UX we want should be based on the current theme/host config. There is no place where the host can override this behaviour of getting the input view and applying the border/colour filter to it.
PFA screenshot of the default behaviour and expected host behaviour (teams client) :
Default behaviour :
Expected behaviour :
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (5 by maintainers)
Top GitHub Comments
@sowrabh-msft please see @jwoo-msft’s comments above. Thanks.
Fixed via https://github.com/microsoft/AdaptiveCards/pull/4853 Please see https://github.com/microsoft/AdaptiveCards/pull/4852 for the usage.