[iOS][Rendering] Container additional properties aren't exposed to the custom renderer

Platform

What platform is your issue or question related to? (Delete other platforms).

• iOS

Author or host

Host

Version of SDK

2.4.6

Details

Similar to #5273, additional properties set on a Container element aren’t available in the ACRBaseCardElementRenderer custom renderer subclass.

        acrRegistration.setBaseCardElementRenderer(CustomContainerRenderer(), cardElementType: .container)

class CustomContainerRenderer: ACRBaseCardElementRenderer {
    override func render(
        _ viewGroup: (UIView & ACRIContentHoldingView)!,
        rootView: ACRView!,
        inputs: NSMutableArray!,
        baseCardElement acoElem: ACOBaseCardElement!,
        hostConfig acoConfig: ACOHostConfig!) -> UIView! {
        
        let view = ACRContainerRenderer.getInstance()?.render(
            viewGroup,
            rootView: rootView,
            inputs: inputs,
            baseCardElement: acoElem,
            hostConfig: acoConfig)
        
        // this is always empty!
        if let props = acoElem.additionalProperties {
            if let cornerRadius = props["my.cornerRadius"] as? CGFloat {
                view?.layer.cornerRadius = cornerRadius
            }
        }
        
        return view
    }
}

[jscalo]

OK yes, that works. Thanks for the info!

[jwoo-msft]

@jscalo I tested this use case. Unfortunately, I wasn’t able to reproduce the issue. Here is my test card & custom renderer

 {
    "type": "AdaptiveCard",
    "$schema": "http://adaptivecards.io/schemas/adaptive-card.json",
    "version": "1.3",
    "body": [
        {
            "type": "Container",
            "items": [
                {
                    "type": "TextBlock",
                    "text": "Test Card",
                    "wrap": true
                }
            ],
            "my.cornerRadius" : 20.0
        }
    ]
}

Test Code Snippet of Custom Container Renderer

    NSData *additionalProperty = acoElem.additionalProperty;
    XCTAssertTrue(additionalProperty != nullptr);
    NSDictionary *dictionary = [NSJSONSerialization JSONObjectWithData:additionalProperty options:NSJSONReadingMutableLeaves error:nil];
    NSNumber *radius = dictionary[@"my.cornerRadius"];
    XCTAssertTrue([radius floatValue] == 20.0f);

    ACRContainerRenderer *defaultRenderer = [ACRContainerRenderer getInstance];

    UIView *view = [defaultRenderer render:viewGroup rootView:rootView inputs:inputs baseCardElement:acoElem hostConfig:acoConfig];

Swift example

if let props = acoElem.additionalProperty() {
            if let dictionary = try JSONSerialization .jsonObject(with: props, options: JSONSerialization.ReadingOptions.mutableLeaves) as? [NSString: Any]{
                let radius = (dictionary["my.cornerRadius"] as! NSNumber).floatValue
            }
        }

I realized that we need documentation on additional properties for Swift and need additional context. I will update the doc. Meanwhile, additional properties is an NSData, and it has to be deserialized to a dictionary, then it can be queried. I will update the documentation. let me know if you still see this issue. Closing this issue and https://github.com/microsoft/AdaptiveCards/issues/5273. Feel free to re-open it if your issue is not resolved.