question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[iOS][Theming] In iOS 13, native components reflect background color of OS-level theme

See original GitHub issue

Platform

What platform is your issue or question related to? (Delete other platforms).

  • iOS

Author or host

Host on Webex Teams

Version of SDK

AdaptiveCards@v1.2.6

Details

On iOS 13, the backgroundColor of native components reflects the OS-level theme (light or dark) regardless of what’s passed into the HostConfig. For most of these components, it can be overridden in a custom renderer, but the default color should align with the rest of the card (i.e. white or similar). There are some components where this isn’t changeable because they cannot be overridden with custom renderers (ACRPickerView and ACRCellForCompactMode are two examples where this can’t be changed). Since not all of these components are able to be overridden with custom renderers, this causes conflicts with our current app’s theme.

Example of what it looks like out of the box when the OS theme is set to Dark using this template card: file_D8932A6C-5C9D-440C-96E1-7AFD5DC624A4

Root Cause

I believe the reason for this is the use of default for the background colors. There isn’t much documentation around what default maps to, but I believe in iOS 13 it takes on the systemBackground value. In ACRChoiceSetViewDataSourceCompactStyle, the backgrounds for each cell are also set to groupTableViewBackgroundColor which maps to systemGroupedBackgroundColor in iOS 13. There may be other colors as well that I missed.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:6 (6 by maintainers)

github_iconTop GitHub Comments

1reaction
jwoo-msftcommented, Jun 18, 2020

closed as this is configurable from client’s application.

0reactions
shalinijoshi19commented, May 28, 2020

@jwoo-msft what is the work here on the SDK side and is that landing for 1.2.9? I’d rather include it in the next patch for now since I’d like to lock down the release/1.2 branch for this week soon.

Read more comments on GitHub >

github_iconTop Results From Across the Web

barTintColor not working in iOS 15
Hi,. When I run the following code in application(_ :didFinishLaunchingWithOptions) in iOS 15, the bar color turns transparent (thus, showing the black ...
Read more >
Dark mode launch screen in iOS 13 - storyboard
When setting up the Launch Screen storyboard, set the view "Background" color to "System Background Color". This will be white in light mode ......
Read more >
Dark Mode | Apple Developer Documentation
In Dark Mode, the system uses two sets of background colors — called base and elevated — to enhance the perception of depth...
Read more >
Adopt dark theme to your app with iOS 13 | by Takuma Kakehi
In WWDC 19, Apple unveiled iOS 13 featuring the native dark mode that app developers can easily introduce to their app.
Read more >
Theming · React Native Paper
In opposition to light theme, dark theme by default uses surface colour instead of primary on large components like AppBar or BottomNavigation ....
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found