[iOS][Theming] In iOS 13, native components reflect background color of OS-level theme
See original GitHub issuePlatform
What platform is your issue or question related to? (Delete other platforms).
- iOS
Author or host
Host on Webex Teams
Version of SDK
AdaptiveCards@v1.2.6
Details
On iOS 13, the backgroundColor
of native components reflects the OS-level theme (light or dark) regardless of what’s passed into the HostConfig. For most of these components, it can be overridden in a custom renderer, but the default color should align with the rest of the card (i.e. white or similar). There are some components where this isn’t changeable because they cannot be overridden with custom renderers (ACRPickerView and ACRCellForCompactMode are two examples where this can’t be changed). Since not all of these components are able to be overridden with custom renderers, this causes conflicts with our current app’s theme.
Example of what it looks like out of the box when the OS theme is set to Dark using this template card:
Root Cause
I believe the reason for this is the use of default
for the background colors. There isn’t much documentation around what default
maps to, but I believe in iOS 13 it takes on the systemBackground
value. In ACRChoiceSetViewDataSourceCompactStyle
, the backgrounds for each cell are also set to groupTableViewBackgroundColor
which maps to systemGroupedBackgroundColor
in iOS 13. There may be other colors as well that I missed.
Issue Analytics
- State:
- Created 3 years ago
- Comments:6 (6 by maintainers)
Top GitHub Comments
closed as this is configurable from client’s application.
@jwoo-msft what is the work here on the SDK side and is that landing for 1.2.9? I’d rather include it in the next patch for now since I’d like to lock down the release/1.2 branch for this week soon.