Add Namespace to Metrics.
See original GitHub issueApplication Insights custom metrics are currently stored in a backend repository optimized for storing structured events from where they are made available for various user experiences in the Azure Portal (Ibiza), in the Analytics Portal and via the DRAFT APIs. These backends identify a metric within the scope of a resource by a 1-tuple [Metric Name]. In the future, custom metrics will be primarily stored in the Geneva pipeline (a backend repository that is optimized for storing timeseries) and made available via the Azure Monitoring APIs [https://docs.microsoft.com/en-us/rest/api/monitor/metrics/list]. Those backends identify a metric within the scope of a resource by a 2-tuple [Metric Namespace, Metric Name]. In order to support these new backends we need to add namespace as an additional attribute to Metric Telemetry Items as a sibling to name wherever name appears. Also, need to add API overloads that create metric items while specifying namespace.
Specifically:
-
Add an attribute
metricNamespace
to the bond spec of DataPoint next toname
. (We call itmetricNamespace
rather thannamespace
to avoid clashed with the frequently used keyword “namespace”) -
Add a property
MetricNamespace
to theMetricTelemetry
class. -
For each ctor of
MetricTelemetry
class that includes aname
parameter, add an overload that also expects a parametermetricNamespace
. -
Add an Obsolete Attribute to each ctor of the
MetricTelemetry
class that includes aname
parameter, but not ametricNamespace
parameter. -
Add / update unit tests according to the above changes.
Thank you, all, for your feedback about these upcoming changes!
Issue Analytics
- State:
- Created 5 years ago
- Comments:19 (19 by maintainers)
This time it worked.
ns
in bond,metricNamespace
in the API.That would help 😃
This week we’re reviewing all open items and closing or assigning to milestones. If this discussion still has pending work, feel free to open additional issues linked to this.