Weird applicactionInsights.config after NuGet package update

HI,

I’ve noticed that AI config file became pretty strange after I’d updated from 2.2.0 to 2.5.1 version. Here’s the weird section:

		<Add Type="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.AdaptiveSamplingTelemetryProcessor, Microsoft.AI.ServerTelemetryChannel">
			<MaxTelemetryItemsPerSecond>5</MaxTelemetryItemsPerSecond>
			<ExcludedTypes>Event</ExcludedTypes>
		</Add>
		<Add Type="Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.AdaptiveSamplingTelemetryProcessor, Microsoft.AI.ServerTelemetryChannel">
			<MaxTelemetryItemsPerSecond>5</MaxTelemetryItemsPerSecond>
			<IncludedTypes>Event</IncludedTypes>
		</Add>

Steps to reproduce:

1. Create an ASP.NET MVC project using VS 2017.
2. Check that the version of AI package is 2.2.0 (or, probably, just lower than 2.5.1)
3. Check that ApplicationInsights.config has only one section for Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel.AdaptiveSamplingTelemetryProcessor. In my case it didn’t contain neither Included nor Excluded types subsection.
4. Upgrade the package to 2.5.1
5. Observe the changes in ApplicationInsights.config.

Could you please clarify the following questions:

1. Is it an expected behaviour?
2. If so, what would that mean? How can sampling be turned off and on at the same time?

Thanks

[zakimaksyutov]

@drauch, this is a little bit more complicated =)

ExcludedTypes indeed means “types you don’t want to be sampled”. But this refers to individual sampling telemetry processor.

In default configuration we add two telemetry processors. One with excluded events, another one with included events. The first one doesn’t touch events. But the second one touches only events.

Please let me know whether this clarifies…

[drauch]

In https://docs.microsoft.com/en-us/azure/azure-monitor/app/sampling#configuring-adaptive-sampling-for-aspnet-applications it sounds like ExcludedTypes means “types you don’t want to be sampled” and not “all other types are being sampled”.