Refactor to use System.Text.Json

Is your feature request related to a problem? Please describe. App inspector deserializes using Newtonsoft.Json, accordingly it ignores System.Text.Json attributes. If you were to extend an AI rule with more attributes and then call AddString, even if you the T is specified the deserialization may not be correct if your json properties dont match the attribute names or if they have special handling.

Any downstream users who implement extensions to AI (like DevSkim) are then required to include newtonsoft for the annotations to use the AddString methods.

Describe the solution you’d like Ideally AppInspector could just use System.Text.Json for serialization in the rules path, using the standard attributes.

[gfs]

Also, no concerns about using the string version in the HTML report, as mentioned earlier we are in planning to replace it with an improved implementation. That is a known limitation of the current HTML report that won’t be addressed until the rewrite.

[dbalikhin]

I think I found alternative solution to simply use StreamWriter. It should save some memory and it copies logic from TextWriter in AI. Please take a look and probably do benchmarks (I pushed my changes). Please note that HTML Writer will still use the string in memory, because it was existing behaviour. But SARIF and JSON Writers are good to go. Now it will use this: JsonSerializer.Serialize(StreamWriter.BaseStream, log); StreamWriter plays nice with Console output and it inherits from TextWriter.