DeleteFilesV1 patterns don't find files/folders starting with a dot

Environment

• Server - Azure Pipelines
• Agent - Private
  • Windows Server 2016 x64 with Agent 2.144.2

Issue Description

The task DeleteFilesV1 doesn’t find files or folders starting with a dot with its patterns. This differs from CopyFilesV2, which does copy files/folders starting with a dot. So if you use the same pattern in both a copy and a delete task, not all copied files will be deleted.

The problem is here: https://github.com/Microsoft/azure-pipelines-tasks/blob/master/Tasks/DeleteFilesV1/deletefiles.ts#L59-L65 Custom matchOptions are passed, but dot: true is not set. Compare to https://github.com/Microsoft/azure-pipelines-task-lib/blob/master/node/task.ts#L1413-L1426 where this and many other options are set by default, but not used for DeleteFilesV1 because custom options are passed.

Task logs

Nothing interesting here

2019-01-30T15:04:12.6948075Z ##[section]Starting: Delete archived source
2019-01-30T15:04:12.6952288Z ==============================================================================
2019-01-30T15:04:12.6952378Z Task         : Delete Files
2019-01-30T15:04:12.6952431Z Description  : Delete files or folders. (The minimatch patterns will only match file paths, not folder paths)
2019-01-30T15:04:12.6952484Z Version      : 1.1.6
2019-01-30T15:04:12.6952552Z Author       : Microsoft Corporation
2019-01-30T15:04:12.6952604Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkID=722333)
2019-01-30T15:04:12.6952929Z ==============================================================================
2019-01-30T15:04:16.4039069Z ##[section]Finishing: Delete archived source

[mjroghelia]

@anatolybolshakov Sounds like a task issue. Could you please investigate?

[vladislav-ryzhov]

Let me close it at the moment since it’s resolved - please let us know if you have any further questions!