powershell task should now prefer `pwsh` on mac/linux

The executable has changed now for powershell core to pwsh instead of powershell, even on Windows. On Mac/Linux we should definitely prefer pwsh and fallback to powershell for back-compat. On Windows, I think we should just try powershell since I’m not sure why that wouldn’t be in the PATH and preferring pwsh seems incorrect.

[ericsciple]

fixed in master https://github.com/Microsoft/vsts-tasks/pull/6175

will roll out with the next deployment. the next deployment starts next week and will roll out over a week or two.

[dhabierre]

I’ve found my problem.

I am using Terraform to create and setup a Linux agent with the remote-exec provisionner:

provisioner "remote-exec" {
  inline = [
    # Powershell
    # --------------------------------------------------------------------------------
    "sudo snap install powershell --classic",
    "sudo pwsh -NoLogo -NoProfile -NonInteractive -Command Install-Module PowerShellGet -Repository PSGallery -Force",
    "sudo pwsh -NoLogo -NoProfile -NonInteractive -Command Install-Module Az -AllowClobber -Force",
    # Azure DevOps Agent
    # --------------------------------------------------------------------------------
    "mkdir agent && cd agent",
    "wget https://vstsagentpackage.azureedge.net/agent/2.163.1/vsts-agent-linux-x64-2.163.1.tar.gz",
    "tar zxvf ./vsts-agent-linux-x64-2.163.1.tar.gz",
    "./config.sh --unattended --url ${var.serverUrl} --auth pat --token ${var.pat} --pool ${var.agentPool} --agent ${azurerm_virtual_machine.virtualmachine[count.index].name}",
    "sudo ./svc.sh install && sudo ./svc.sh start"
  ]

When executing the ./config.sh command, the file .path is created with the current $PATH and it is used to setup the PATH capability. But but the path does not contains /snap/bin folder!

And thus the Azure Powershell Task failed with which pwsh => not found.

=> set the PATH before executing ./config.sh:

provisioner "remote-exec" {
  inline = [
    # Powershell
    # --------------------------------------------------------------------------------
    <...>
    # Azure DevOps Agent
    # --------------------------------------------------------------------------------
    "mkdir agent && cd agent",
    "wget https://vstsagentpackage.azureedge.net/agent/2.163.1/vsts-agent-linux-x64-2.163.1.tar.gz",
    "tar zxvf ./vsts-agent-linux-x64-2.163.1.tar.gz",
    # *******************************************************************************************
    "export PATH=\"$PATH:/snap/bin\"",
    # *******************************************************************************************
    "./config.sh --unattended --url ${var.serverUrl} --auth pat --token ${var.pat} --pool ${var.agentPool} --agent ${azurerm_virtual_machine.virtualmachine[count.index].name}",
    "sudo ./svc.sh install && sudo ./svc.sh start"
  ]