Danish Language Support in Confirm Prompt Bot v4 (C#/.Net Core)

Danish Language is not supported by the Confirm Prompt Class and no way provided to extend it.

Version

v4.5.0

Describe the bug

Danish Language is not supported by the Confirm Prompt Class and no way provided to extend it. Essentially, this code is required - { Danish, (new Choice("Ja"), new Choice("Nej"), new ChoiceFactoryOptions(", ", " of ", ", of ", true)) },

Take a look at code here - https://github.com/microsoft/botbuilder-dotnet/blob/master/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/ConfirmPrompt.cs

To Reproduce

Steps to reproduce the behavior:

1. Add a Confirm Prompt in V4 Bot
2. Try to set Default Locale to Danish

Expected behavior

Danish Locale should be added. And it should be made configurable/injectable for different languages to make it decoupled.

Additional context

Please take action on this as soon as possible.

[cleemullins]

Two points here:

Point 1:

Given that our [recognizers library] (https://github.com/Microsoft/Recognizers-Text) doesn’t support Danish, I don’t think this is a change we can take. To do this, we would have to start with the recognizers, then move up the stack.

Point 2: We should allow you to extend this.

I would support something like:

public static void AddDefaultChoiceItem( ... )
{
}

That would be run at startup, or some similar time, and would modify the static dictionary.

Would that work?

A more flexible option may be to have:

public static void SetDefaultChoices(Dictionary<>) which replaces the entire dictionary. 

[mutanttech]

@mdrichardson, Thanks for update. I will take reference from from the PR.