OAuthPrompt in v4.10.3 + Generic Oauth 2 + IdentityServer = No prompt is shown

OAuthPrompt in Microsoft.Bot.Builder.Dialogs v4.10.3 seems to be broken when using the connection name of “Generic Oauth 2” service provider - it is not displayed in Teams dialog with the bot, nor in WebChat.

To Reproduce

1. Set up an IdentityServer instance locally, which needs to have the client configured as follows:

• ClientId: your_client_id
• ClientSecret: your_client_secret
• RedirectUris: ["https://token.botframework.com/.auth/web/redirect"]
• RequireConsent: false
• AllowOfflineAccess: true,
• AllowedScopes: ["openid", "profile"],
• AllowedGrantTypes: ["authorization_code"],
• RequirePkce: false, <-- necessary so Bot services can use it, as Bot services don’t seem to support PKCE
• RefreshTokenUsage: TokenUsage.ReUse <-- the Bot services seem unable to handle the one-time refresh tokens

1. Configure the Generic Oauth 2 service provider in Bot Channels registration so it points to the IdentityServer instance (you can use ngrok to host the IdentityServer instance) like this:

• Client id: your_client_id,
• Client secret: your_client_secret,
• Authorization URL: https://<your identity server address>/connect/authorize,
• Token URL: https://<your identity server address>/connect/token,
• Refresh URL: https://<your identity server address>/connect/token,
• Scopes: openid profile

1. Start from the Teams Auth sample
2. Edit appsettings.json to enter the valid credentials and use the connection name of AADv2 service provider
3. Start the bot, type “hi” or whatever in Teams conversation with the bot and it will display a sign-in card.
4. Stop the bot, go back to appsettings.json and change the connection name to have the name of the configured Generic Oauth 2 service provider connection name
5. Start the bot again, type “hi” or whatever in Teams convo with the bot and it won’t display anything.

Screenshots

The configuration of Generic OAuth 2 service provider connection:

Additional context

This is the output from VS debugging:

Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker: Information: Route matched with {action = "Post", controller = "Bot"}. Executing controller action with signature System.Threading.Tasks.Task PostAsync() on controller Microsoft.BotBuilderSamples.BotController (TeamsAuth).
Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter: Information: Received an incoming activity.  ActivityId: 1605218380039
Microsoft.BotBuilderSamples.DialogBot: Information: Running dialog with Message Activity.
TeamsAuth Information: 0 : 'hi' ==> beginDialog      ==> MainDialog 
TeamsAuth Information: 0 : 'hi' ==> beginDialog      ==> WaterfallDialog 
TeamsAuth Information: 0 : 'hi' ==> beginDialog      ==> OAuthPrompt 
Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter: Information: GetTokenAsync: Acquired token using ADAL in 0.
Exception thrown: 'Microsoft.Rest.TransientFaultHandling.HttpRequestWithStatusException' in Microsoft.Rest.ClientRuntime.dll
Exception thrown: 'Microsoft.Rest.TransientFaultHandling.HttpRequestWithStatusException' in System.Private.CoreLib.dll
Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter: Information: GetTokenAsync: Acquired token using ADAL in 0.
Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter: Information: Sending activity.  ReplyToId: 1605218380039
Microsoft.Bot.Builder.Integration.AspNet.Core.BotFrameworkHttpAdapter: Information: GetTokenAsync: Acquired token using ADAL in 0.
Microsoft.AspNetCore.Mvc.Infrastructure.ControllerActionInvoker: Information: Executed action Microsoft.BotBuilderSamples.BotController.PostAsync (TeamsAuth) in 746.9577ms
Microsoft.AspNetCore.Routing.EndpointMiddleware: Information: Executed endpoint 'Microsoft.BotBuilderSamples.BotController.PostAsync (TeamsAuth)'
Microsoft.AspNetCore.Hosting.Diagnostics: Information: Request finished in 762.0714ms 200 

Note that the sign in via this connection name works fine when used with messaging extensions:

new MessagingExtensionResult
{
    Type = "auth",
    SuggestedActions = new MessagingExtensionSuggestedAction
    {
        Actions = new List<CardAction>
        {
            new CardAction
            {
                Type = ActionTypes.OpenUrl,
                Value = signInAddress,
                Title =  title,
            }
        }
    }
};

Also, if I sign in through the messaging extension first, the OAuthPrompt will correctly retrieve the access token for either requested connection name.

Also… I tried with an older 46.teams-auth sample which used v4.6.2 and it also worked fine. Pls fix 🥇

[dejancg]

@jwiley84 no error message. Just doesn’t show up (you can try with the sample I mentioned, it’s not hard to reproduce). In our application, however, BeginDialogAsync method of OAuthPrompt throws an error with HTTP status code 404.

[dejancg]

@jwiley84 it seems I made a mistake when configuring the Generic Oauth2 provider after all. BotBuilder 4.10 is probably using the Token Exchange URL which wasn’t used by the previous BotBuilder versions. The problem was that I wrongfully set the value of Token Exchange URL to the token endpoint URL, where it had to be left blank. When I cleared the value, since it’s an optional field, the OAuthPrompt started to show, even with 4.10. Please accept my apologies for wasting your time on this issue.