Start fails with "Unable to resolve service for type 'ChannelServiceHandler' while attempting to activate 'ChannelServiceController'.)'

Version

4.7.0

Describe the bug

I’m writing a ASP.NET Core 3.1 C# app where I use several packages of the BotBuilder SDK. What works fine with SDK 4.6.3 now fails with 4.7.0 with the following exception:

System.AggregateException: 'Some services are not able to be constructed (Error while validating the service descriptor 'ServiceType: Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController Lifetime: Transient ImplementationType: Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController': Unable to resolve service for type 'Microsoft.Bot.Builder.ChannelServiceHandler' while attempting to activate 'Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController'.)'

Exception 1/2

InvalidOperationException: Error while validating the service descriptor 'ServiceType: Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController Lifetime: Transient ImplementationType: Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController': Unable to resolve service for type 'Microsoft.Bot.Builder.ChannelServiceHandler' while attempting to activate 'Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController'.

Exception 2/2

InvalidOperationException: Unable to resolve service for type 'Microsoft.Bot.Builder.ChannelServiceHandler' while attempting to activate 'Microsoft.Bot.Builder.Integration.AspNet.Core.ChannelServiceController'.



This exception was originally thrown at this call stack:
	Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateArgumentCallSites(System.Type, System.Type, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain, System.Reflection.ParameterInfo[], bool)
	Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.CreateConstructorCallSite(Microsoft.Extensions.DependencyInjection.ServiceLookup.ResultCache, System.Type, System.Type, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain)
	Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.TryCreateExact(Microsoft.Extensions.DependencyInjection.ServiceDescriptor, System.Type, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain, int)
	Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteFactory.GetCallSite(Microsoft.Extensions.DependencyInjection.ServiceDescriptor, Microsoft.Extensions.DependencyInjection.ServiceLookup.CallSiteChain)
	Microsoft.Extensions.DependencyInjection.ServiceLookup.ServiceProviderEngine.ValidateService(Microsoft.Extensions.DependencyInjection.ServiceDescriptor)

Expected behavior

The application starts fine.

Additional context

Is it possible that this is related to this PR? https://github.com/microsoft/botbuilder-dotnet/pull/3038/files

I also hope that I can build a project to reproduce the error. It currently also only fails when compiling a debug version and running it with the ASP Environment set to Development for whatever reason.

Is there anything I possible did wrong or a cache I need to clear? Like I said, the same code runs fine with version 4.6.3 of all Microsoft.Bot.* packages.

[bug]

[gabog]

Hi @sibbl, we accelerated the fix for this issue and we just released a fix, if you update your project to use 4.7.2 it should work now.

Thanks for the feedback and detailed repro project.

[EricDahlvang]

Hi @sibbl

With Bot Builder 4.7, we introduced a ChannelServiceController. This is being discovered by dependency injection when calling .AddControllersAsServices()

As a workaround, it is possible to exclude the integration library from discovery with something like:

public virtual void ConfigureServices(IServiceCollection services)
        {
            services.AddMvc().ConfigureApplicationPartManager(manager=> 
                {
                    var botAssemblyPart = manager.ApplicationParts.FirstOrDefault(a => a.Name == typeof(ChannelServiceController).Assembly.GetName().Name);
                    manager.ApplicationParts.Remove(botAssemblyPart);
                })
            .AddControllersAsServices();
            
 
            services.AddSingleton<IBotFrameworkHttpAdapter, BotFrameworkHttpAdapter>();
 
            services.AddTransient<IBot, GenericBot>();
        }

Or by using a custom ControllerFeatureProvider to filter out the ChannelServiceController

We will raise this issue with the team, and come up with a better long term solution.