question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

[BotBuilder] TestFlow class does not match C# counterpart

See original GitHub issue

Versions

What package version of the SDK are you using. botbuilder@^4.8.0 What nodejs version are you using v12.16.1 What browser version are you using What os are you using Windows 10 Pro

Describe the bug

The JavaScript implementation of TestFlow does not offer the same capabilities of its C# implementation.

Attempting to implement some functionalities based on the C# implementation of TestFlow is not possible to use the JavaScript version, especially those that rely on the BotCallbackhandler since its missing from JavaScript.

To Reproduce

  1. Clone BotBuilder-DotNet.
  2. Navigate to /libraries/Microsoft.Bot.Builder/Adapters/
  3. Open TestFlow.cs
  4. Clone BotBuilder-JS.
  5. Navigate to /libraries/botbuilder-core/src/
  6. Open testAdapter.ts, scroll down to line 537.
  7. Compare both implementations of TestFlow

Expected behavior

I expect TestFlow in JavaScript to use the same implementation as in C#.

Screenshots

TestFlow C# vs TestFlow JavaScript

image

Additional context

While migrating bot-solution from the botframework-solutions repository tests, we found that C# uses the callback’s context to set the userProfileState, however, that is not possible to do it with the current implementation of TestFlow in JavaScript.

At the moment we rely on using TestAdapter, but neither uses the BotCallbackHandler.

[bug]

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (4 by maintainers)

github_iconTop GitHub Comments

6reactions
stevkancommented, May 7, 2020

@VictorGrycuk, thank you for bringing this to our attention. We’ll begin bringing the two SDKs into parity. Please feel free to check back here for updates as work progresses.

1reaction
stevkancommented, Aug 13, 2020

@stevengum, PR is near to being submitted for review. Working on writing tests and running, then will submit.

Read more comments on GitHub >

github_iconTop Results From Across the Web

TestFlow class - Microsoft Learn
Generates an assertion if the bots response doesn't match the expected text/activity. assertReplyOneOf(string[], string, number). Generates an assertion if the ...
Read more >
Bot Framework Package versions mismatch has broken Bot
Went to deploy my bot via Bot Framework Composer & got the following fail output: Build FAILED. C ...
Read more >
'System.IdentityModel.Tokens.Jwt 5.1.4' is not compatible with ...
Jwt 5.1.4' is not compatible with 'Microsoft.Bot.Builder 3.8.2 ... The located assembly's manifest definition does not match the assembly reference.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found