[BotBuilder] TestFlow class does not match C# counterpart
See original GitHub issueVersions
What package version of the SDK are you using. botbuilder@^4.8.0 What nodejs version are you using v12.16.1 What browser version are you using What os are you using Windows 10 Pro
Describe the bug
The JavaScript implementation of TestFlow
does not offer the same capabilities of its C# implementation.
Attempting to implement some functionalities based on the C# implementation of TestFlow
is not possible to use the JavaScript version, especially those that rely on the BotCallbackhandler
since its missing from JavaScript.
To Reproduce
- Clone BotBuilder-DotNet.
- Navigate to
/libraries/Microsoft.Bot.Builder/Adapters/
- Open
TestFlow.cs
- Clone BotBuilder-JS.
- Navigate to
/libraries/botbuilder-core/src/
- Open
testAdapter.ts
, scroll down to line 537. - Compare both implementations of
TestFlow
Expected behavior
I expect TestFlow in JavaScript to use the same implementation as in C#.
Screenshots
TestFlow
C# vs TestFlow
JavaScript
Additional context
While migrating bot-solution from the botframework-solutions repository tests, we found that C# uses the callback’s context to set the userProfileState, however, that is not possible to do it with the current implementation of TestFlow in JavaScript.
At the moment we rely on using TestAdapter, but neither uses the BotCallbackHandler.
[bug]
Issue Analytics
- State:
- Created 3 years ago
- Comments:11 (4 by maintainers)
@VictorGrycuk, thank you for bringing this to our attention. We’ll begin bringing the two SDKs into parity. Please feel free to check back here for updates as work progresses.
@stevengum, PR is near to being submitted for review. Working on writing tests and running, then will submit.