Receives UnhandledPromiseRejectionWarning message during bot SSO

Github issues should be used for bugs and feature requests. Use Stack Overflow for general “how-to” questions.

Versions

“botbuilder”: “^4.15.0”. Node.js 16-latest chrome-latest windows-latest

Describe the bug

Try this sample when the bot onInvokeActivity directly return 412 in server/bots/botActivityHandler.js the app crash down because BotFrameworkAdapter.processActivity throw exception once there is a 412 response but in the index.ts don’t handle this exception.

Bot Started, restify listening to http://[::]:3978
Debugger attached.
/Users/kimjason/projects/teams-apps/pradeep-sso/query-org-user-with-message-extension-sso/bot/node_modules/botbuilder/src/botFrameworkAdapter.ts:1275
                throw new Error(`BotFrameworkAdapter.processActivity(): ${status} ERROR`);
                      ^
Error: BotFrameworkAdapter.processActivity(): 412 ERROR
    at BotFrameworkAdapter.<anonymous> (/Users/kimjason/projects/teams-apps/pradeep-sso/query-org-user-with-message-extension-sso/bot/node_modules/botbuilder/src/botFrameworkAdapter.ts:1275:23)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/kimjason/projects/teams-apps/pradeep-sso/query-org-user-with-message-extension-sso/bot/node_modules/botbuilder/lib/botFrameworkAdapter.js:12:58)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
Waiting for the debugger to disconnect...
[nodemon] app crashed - waiting for file changes before starting...

To Reproduce

Steps to reproduce the behavior:

1. clone the sample
2. do as the sample readme
3. you may update the code in onInvokActivity to return 412 directly in server/bots/botActivityHandler.js
4. See error

Expected behavior

The App should not crash down.

Screenshots

Additional context

Or any other suggestion?

[ceciliaavila]

Hi everyone, We found a similar issue that was closed because, for SSO flows, the 412 errors are frequent, and in case you want to ignore them, you should catch them in the bot’s code. Additionally, as BotFrameworkAdapter is deprecated, the recommended path is to use CloudAdapter. We tested the sample using CloudAdapter, and the app doesn’t crash when facing 412 errors because it doesn’t get any UnhandledPromiseRejectionWarnings. We believe this issue should be closed, and we recommend applying one of the above solutions.

[JuanAr]

Hi @JuanAr,

It appears we are able to repro this issue. Assigned this to you.

Please let me know if you have any questions. Happy to provide additional info. Thanks.

Hi @ramfattah, thanks for reporting and details. We added this issue to our backlog and we’ll be tackling it next week.

Thanks, Juan