Installing a package while a bot is running results in multi-project build errors
See original GitHub issueDescribe the bug
If you install a package while a bot is running the underlying process isn’t fully killed. As a result Composer gets into a bad state where the Restart bot
button becomes Start bot
but there’s already an process running.
Version
Version: 2.0.0-nightly.241057.db66154 Electron: 8.2.4 Chrome: 80.0.3987.165 NodeJS: 12.13.0 V8: 8.0.426.27-electron.0
Browser
- Electron distribution
- Chrome
- Safari
- Firefox
- Edge
OS
- macOS
- Windows
- Ubuntu
To Reproduce
Steps to reproduce the behavior:
- Create or open a bot and start it
- Install a package (I did the Teams package)
- Note how the
Restart bot
button becomesStart bot
after the package is installed - Click the
Start bot
button
Expected behavior
The button should either be Start bot
where the underlying process is actually killed, or it should be Restart bot
assuming restart rebuilds with any delta in the packages
Screenshots
Additional context
Error occurred building the bot
Message: Command failed: dotnet build TeamsTest.csproj Command: dotnet build TeamsTest.csproj Stack Trace: Error: Command failed: dotnet build TeamsTest.csproj
at ChildProcess.exithandler (child_process.js:308:12)
at ChildProcess.emit (events.js:210:5)
at maybeClose (internal/child_process.js:1021:16)
at Process.ChildProcess._handle.onexit (internal/child_process.js:283:5)
Output: Microsoft ® Build Engine version 16.9.0+57a23d249 for .NET Copyright © Microsoft Corporation. All rights reserved.
Issue Analytics
- State:
- Created 2 years ago
- Comments:7 (7 by maintainers)
Top GitHub Comments
@mareekuh @emivers8 @sgellock I think it’s important to let the user know that installing a new package requires stopping their bot, if they agree, then composer stops their bot and continues with the installation, if not composer informs the user that they need to stop their running bot before any installation can happen.
Shiproom - approved