OAuth emulation presents a blank child window when clicking the authenticate button of the OAuth card

Version

4.2.1

Describe the bug

So I started reporting this bug on the back of the initial issue where the OAuth endpoint was not working at all, but it’s clear now that this needs to be its own bug. The details are as follows:

Clicking the authenticate button of the OAuth card results in a blank child window being popped up which dead ends the entire authentication process making the OAuth emulation unusable.

To Reproduce

Steps to reproduce the behavior:

1. Have the bot send out the OAuth card
2. Click on the authenticate button in the card
3. Stare at the blank child window and wonder what you did wrong 😜

Expected behavior

I would expect the same, default behavior as the v3 emulator which would be to generate an emulated auth token and trigger the TokenResponse event within the bot with that token. No actual sign in UI need be popped up.

Screenshots

Additional context

Users are also experiencing this as is evidenced by this StackOverflow Question.

[bug]

[drub0y]

@justinwilaby Thanks for giving me some of your time today. I just want to follow up with what we discovered so the details are here whenever you’re able to return to this issue.

At first, when I attempted to repro this for you, suddenly everything worked as expected. I later determined this was because I was not connected to the network and this must be triggering some behavior to fail which then causes the correct behavior to succeed.

What we determined is that there are two pieces of code responsible for enriching an OAuth card coming from the bot:

1. oauthLinkEncoder which is the one that is setting the oauthlink: protocol and fetching the signin link by calling through the getUserSignIn process. This encoder is run as part of the replyToActivity middleware.
2. oauthClientEncoder which is the one that sets the oauth: protocol and correctly takes the connectionName out of the Activity and embeds it in the link. The encoder is run as part of the Conversation::processActivity.

When the emulator is online, #1 - oauthLinkEncoder always wins. When offline, #2 - oauthClientEncoder always wins.

The expectation is that, in this specific scenario, #2 - oauthClientEncoder should always be winning.

[justinwilaby]

The root cause has been located thanks to the hard work and persistence from @drub0y. Starting the fix now.