[NodeJS] ERROR: Too many calls to session.endDialog()

I’ve been refactoring our full Botkit code to botbuilder this past days and so far it has been and it has been great in taking a major load of the code in managing dialogs (-ues).

I’m currently working with v0.9.x, and while its been great, I’d like to ask on why and what plans are ahead on the ERROR: Too many calls to session.endDialog().-response I get when an error is thrown within the code.

Reason being, it doesn’t give me any meaningful idea on what caused the issue. Are there any tips or commands I’m missing?

Thanks! #

[Stevenic]

So the other issue I noticed is with your respondToSpecificFoo() function. You call session.endDialog() which of itself is fine. It will pop that dialog off the stack and return control to the dialog you came from (think of it as calling close window.) The issue is in your async callback for SomeApi.getSpecificFoo() you’re then calling session.send(). I’m assuming this is working ok but it’s a little dangerous.

The reason why its dangerous is that you’ve already ended your dialog (closed the window) and now you’re trying to say stuff in that context. In most cases nothing overly bad is going to happen, especially with send() but say you tried to call beginDialog() instead, you would totally jackup your callstack. So as a best practice you should avoid doing stuff like this. So how to do this the right way? You should move your endDialog() call into your callback and combine it with the send():

function respondToSpecificFoo(session, results) {
    var targetDate = moment(results.response.date);

    SomeApi.getSpecificFoos(targetDate, function (err, totalFoos) {
        var queryResponse = '';

        if (moment().isSame(targetDate, 'day')) {
            queryResponse = 'You have ' + totalFoos.toLocaleString() + ' foos for today!';
        } else {
            queryResponse = 'You have ' + totalFoos.toLocaleString() + ' foos for ' + moment(targetDate).format('MMMM D, YYYY') + '!';
        }

        session.endDialog(queryResponse);
    });
}

[deubaka]

@Stevenic Thank you for tip. I’ve changed the code and yes, it does go away so far.

I’ll go ahead and make changes to our code accordingly if any, and await for a new release. Thanks! 😃