ScriptDom parser for Sql Server 2022 fails to parse IGNORE NULLS clause

• SqlPackage or DacFx Version: 160.6266.0-preview
• .NET Framework (Windows-only) or .NET Core: .NET 6.0 (Core)
• Environment (local platform and source/target platforms): N/A

Steps to Reproduce:

1. Create a new C# Console Project
2. Add latest Nuget package for Microsoft.SqlServer.DacFx (160.6266.0-preview)
3. Run code below

using Microsoft.SqlServer.TransactSql.ScriptDom;

var parser = new TSql160Parser(true); //sql server 2022 parser
IList<ParseError> errors;

parser.ParseExpression(new StringReader("LAST_VALUE(Measure) OVER()"), out errors);
//no parsing errors

parser.ParseExpression(new StringReader("LAST_VALUE(Measure) IGNORE NULLS OVER()"), out errors);
//parsing error! "Incorrect syntax near IGNORE." This should parse succesfully

Console.ReadLine();

Did this occur in prior versions? If not - which version(s) did it work in? Not applicable because the Sql Server 2022 parser (TSQL 160 didn’t exist in prior versions).

Documentation about the support for IGNORE NULLS / RESPECT NULLS in Sql Server 2022 is here: https://docs.microsoft.com/en-us/sql/t-sql/functions/last-value-transact-sql?view=sql-server-ver16#-ignore-nulls--respect-nulls-

[clement911]

@zijchen I can confirm that parsing of the expression above now works on version 161.6337.0-preview.

However, I find the object model weird. Why is the IgnoreRespectNulls property a list of Identifiers?

public IList<Identifier> IgnoreRespectNulls { get; }

We would expect a proper Fragment class IgnoreRespectNullsClause or maybe a simple a simple enum

Maybe something along the following lines?

public enum IgnoreRespectNulls
{
  NotSpecified,
  IgnoreNulls,
  RespectNulls
}

p.s.: I also tested a long standing bug causing the parser to fail to parse nested IIF calls. I’m pleased to see this appears to be fixed!

[clement911]

I see a new stable version of the package was released yet this is still not fixed