CheckpointSettings.RemoveOutdated does not remove checkpoints between recoveries

I’ve been testing FasterKV with CheckpointSettings.RemoveOutdated set to true to avoid polluting the directory. So far it seems like this will only remove checkpoints within one lifetime of FasterKV. If my application restarts and re-create FasterKV, the old checkpoints are not removed. So I tried to delete the checkpoint after recovering, and it seems to work:

var store = new FasterKV(...);
store.Recover();
if(Directory.Exists(checkpoint_dir)){
   Directory.Delete(checkpoint_dir, recursive:true);
}

My question is: is it a safe thing to do? Will it impact the correctness of the FasterKV store?

[dhhoang]

By looking at the code, it seems obvious: checkpointManager.OnRecovery is called in InternalRecover but not in InternalRecoverAsync: https://github.com/microsoft/FASTER/blob/f8cc6ea7366d399388f977e9762e2822d54f4dec/cs/src/core/Index/Recovery/Recovery.cs#L327

[badrishc]

Thanks for pointing out this divergence - we have fixed the isssue in latest on master branch.