Replace Hard-coded Paths with Already Existing Variable

Problematic

At the end of the YAML for the continuous integration example, the upload-artifact step path uses a hard coded folder path:

https://github.com/microsoft/github-actions-for-desktop-apps/blob/d0fbf5cbc39057dea30244fb7ef6c5ae9c3b1ab8/.github/workflows/ci.yml#L93

Recommended

I believe this should be using the Wap_Project_Directory variable plus “AppPackages” subfolder instead.

Snippet

# Upload the MSIX package: https://github.com/marketplace/actions/upload-artifact
- name: Upload build artifacts
  uses: actions/upload-artifact@v1
  with:
    name: MSIX Package
    path: '$env:Wap_Project_Directory\AppPackages\'

[Edit] - Added the subfolder name to the variable. I’m not sure that’s how to concatenate the variable with a string in GitHub actions yet, but you get the point

[lindexi]

[LanceMcCarthy]

Since you already need the matrix variable for channel name, it wouldn’t be too much fluff to add another variable. However, the who point of a variable is that it’s value is different, so it defeats the purpose to have the same value in each matrix.

So instead, you could just add a comment where things are hard-coded. For example:

 # We need to use full path here because job variable is not in scope
 path: MyWpfApp.Package\AppPackages\ 

That way, developers who might clone/copy from this repo wont get hung up on a path that doesn’t exist in their app (you know folks are going to copy/paste without drilling deeper into each value).