question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

ContentDialog Text Color Contrast

See original GitHub issue

Describe the bug The color contrast of hyperlinks and text in a ContentDialog does not meet the color contrast ratio of 4.5:1 for accessibility.

https://github.com/microsoft/terminal/issues/5395 is dependent on a fix for this issue.

Steps to reproduce the bug This can be seen in Windows Terminal’s TerminalPage.xaml , but this just uses the built-in theme dictionaries.

Steps to reproduce the behavior:

  1. Open your app of choice that uses a ContentDialog using HyperlinkButtons
  2. Open Accessibility Insights (download link here) to check the color contrast ratio
  3. Verify whether the color contrast ratio for the SplitButton control meets the 4.5:1 contrast ratio

Expected behavior In Windows Terminal, the links present in the “About” pop up window and the text to the back ground color in the “OK” button should meet the color contrast ratio 4.5:1

Screenshots image

image

Version Info

NuGet package version:

Windows 10 version Saw the problem?
Insider Build (xxxxx)
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)
Device form factor Saw the problem?
Desktop
Mobile
Xbox
Surface Hub
IoT

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:8 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
mdtaukcommented, Apr 30, 2020

When choosing an Accent Color, it does warn where there could be visibility problems - so if the user has chosen such a colour - then we can presume they take that risk.

The Windows team should have chosen an accent colour that meets contrast ratio recommendations right?

0reactions
StephenLPeterscommented, Dec 17, 2020
Read more comments on GitHub >

github_iconTop Results From Across the Web

ContentDialog Class (Windows.UI.Xaml.Controls)
Represents a dialog box that can be customized to contain checkboxes, hyperlinks, buttons and any other XAML content.
Read more >
A11y_Windows Terminal_About_Color Contrast: ...
Open the "Accessibility insights" tool to check color contrast ratio; Tab to "Dropdown" control and press enter or use "Ctrl + Shift +...
Read more >
c# - ContentDialog - Remove / change color around
I have a ContentDialog on my Universal Windows Application. When are showed, the space around it, is white with transparency. If change opacity, ......
Read more >
ContentDialog - Remove / change color around - Windows 10-C
Try to change the Request Theme of your Content Dialog or your Page. ... Change button color to white when changing windows theme...
Read more >
August | 2017 | XAML Brewer, by Diederik Krols
Basically we need a control to display some text(s), one, two, or three buttons, an optional input field, and an overlay to cover...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found