Data-bound value not adjusted to fall into range for NumberBox

Describe the bug

When NumberBox has a Minimum/Maximum range set and the data-bound Value does not fall within this range, one of the boundary values is displayed in the control, but the boundary value is not propagated to the view model.

Steps to reproduce the bug XAML:

<winui:NumberBox Minimum="2" Maximum="6" Value="{x:Bind Test, Mode=TwoWay}" />

C#:

public float Test {get; set;} = 0;

Now add a button that displays the value of Test in debug output. Notice that although number box shows “2”, the output value is still 0, unless user modifies the value in any way.

Expected behavior

I would expect that the view model value would update accordingly when the “invalid” value is first bound.

Version Info

NuGet package version:

Microsoft.UI.Xaml 2.4.0

Windows 10 version	Saw the problem?
Insider Build (xxxxx)
May 2020 Update (19041)	Yes
November 2019 Update (18363)
May 2019 Update (18362)
October 2018 Update (17763)
April 2018 Update (17134)
Fall Creators Update (16299)
Creators Update (15063)

Device form factor	Saw the problem?
Desktop	Yes
Xbox
Surface Hub
IoT

Additional context

I have noticed the Slider control behaves the same way as well.

[chingucoding]

Oh right, yes there a negation to much in there, you are right @StephenLPeters !

[StephenLPeters]

Right, yes. I don’t think it’s not that time critical. If you need help with setting up the repro or getting started, feel free to ask!

I don’t think its time critical

I think there was a mistaken double negative. @MartinZikmund go for it, looking foreword to the PR.